Post events #30
Open
Post events #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firebase: 4.13.1 -> 5.7.0 react: 15.4.2 -> 16.6.3 react-dom: 15.4.2 -> 16.6.3. Changes to be committed: modified: package-lock.json modified: package.json
Changes to be committed: modified: src/components/ClassroomComponent/BookingComponent/BookingComponent.js modified: src/components/ClassroomComponent/MyEventsComponent/MyEventsComponent.js new file: src/components/ClassroomComponent/PostEventComponent/FinishedContainer.js new file: src/components/ClassroomComponent/PostEventComponent/postEventContainer.js new file: src/components/EditTable/EditTable.js modified: src/index.js modified: src/reducers/userReducer.js
|
Run |
Fix all issues thrown when npm run test is used. modified: src/components/ClassroomComponent/BookingComponent/BookingComponent.js modified: src/components/ClassroomComponent/MyEventsComponent/MyEventsComponent.js modified: src/components/ClassroomComponent/PostEventComponent/FinishedContainer.js modified: src/components/ClassroomComponent/PostEventComponent/postEventContainer.js modified: src/components/EditTable/EditTable.js modified: src/index.js modified: src/reducers/userReducer.js
|
Fixed linting issues. |
bhawesh96
force-pushed
the
master
branch
2 times, most recently
from
89e89fa to
37c8f16
Compare
rsarky
force-pushed
the
master
branch
2 times, most recently
from
e9a1a87 to
1e6c233
Compare
modified: package-lock.json modified: package.json modified: src/components/ClassroomComponent/PostEventComponent/postEventContainer.js new file: src/components/ClassroomComponent/PostEventComponent/postEventContainer1.js new file: src/components/ClassroomComponent/PostEventComponent/styles.js
modified: src/components/ClassroomComponent/PostEventComponent/postEventContainer.js
modified: src/components/ClassroomComponent/PostEventComponent/postEventContainer.js
modified: src/components/ClassroomComponent/PostEventComponent/postEventContainer.js
|
@bhawesh96 @rsarky check the new updates and tell me for further changes. |
rsarky
force-pushed
the
master
branch
2 times, most recently
from
66c278c to
ee9a445
Compare
|
Can you rebase on master. |
|
so the feature is fine? |
|
There are some issues.
|
|
ping @dheeraj-coding |
Skewed DB updates
checking for required fields.
modified: src/components/ClassroomComponent/PostEventComponent/postEventContainer.js
Add welcome bot configurations to config.yml
Add BACKEND_API env var and use that as baseURL in services Closes cribbl#43
Allow SC to approve/reject/flag an event before FA, AD, SO Closes cribbl#50
AB5 310A and 310B weren't handled properly in the code. Treat them as special cases. style: Style fixes
Changed API endpoint of `sendEmailTemplate` to remove the hardcoded firebase link and just send `event.key` instead. Change case of SO by moving sendEmailTemplate after generatePDF Change API of sendEmailTemplate
Student Council requires to keep track of which rooms are occupied by which club so that they can control the room bookings. This feature helps achieve the Council to get information regarding which event is going to be held at a particular room at a particular day. feat: Additional feature requests by SC on View Bookings (cribbl#69) * Add error message if no event is found * Allow Operations to access View Bookings page Change name from ViewBookings to ViewBookings component
This fixes the mysterious anonymous rooms in roomsx error. For eg. Consider there is a booking for the 29th. Now when someone books rooms from 28-30 the rooms for 29th will incorrectly be added to the roomsx array for 28 and 30 also. This was caused because taken rooms was calculated across all booking dates and then when roomsx was to be updated the same array of takenRooms concatenated with selectedRooms was used to update all dates.
… event to a new function
Bookings tab. This is necessary so the floor incharges can verify event receipts.
Earlier all approved rooms were fetched. In this commit only approved rooms for the selected date are fetched.
Added a `blocked` node on the database that contains blocked rooms for respective days. `fetchRooms` will now fetch the `takenRooms` along with the `blockedRooms`. _TODO_ : Make corresponding changes in View Bookings.
Changes to be committed: modified: src/components/ClassroomComponent/MyEventsComponent/MyEventsComponent.js
@dheeraj-coding can you please check these points? I don't see the changes. |
|
@rsarky , do you think we should scrap this and start afresh on this feature? |
|
Not sure if any existing work can salvaged from this. We could start afresh if there is someone willing to pick this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the post events feature to collect data after completion of event.
Type of Change: