Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional feature requests by SC on View Bookings #69

Merged
merged 2 commits into from
Jan 11, 2019

Conversation

rsarky
Copy link
Member

@rsarky rsarky commented Jan 11, 2019

  • Give Operations access.
  • Add an error message if no event is found.

@rsarky rsarky merged commit 38d407a into cribbl:master Jan 11, 2019
rsarky added a commit that referenced this pull request Jan 13, 2019
Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component
rsarky added a commit that referenced this pull request Jan 13, 2019
Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component
rsarky added a commit that referenced this pull request Jan 13, 2019
Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component
Arushi1912 pushed a commit to Arushi1912/miteb-frontend that referenced this pull request Jan 18, 2019
fix: use baseURL based on environment
Add BACKEND_API env var and use that as baseURL in services

Closes cribbl#43

[skip ci] Update readme

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

Feat: Post Event detail only description
Add dialog to take post event detail description

Relates cribbl#53

fix: Reduce maximum rooms allowed

Maximum rooms a club can book changed from 4 to 3

Closes cribbl#49

Fix: Reduce booking period to 20 days

The maximum date a club can book a room is reduced to 20 days from 1 month.

Closes cribbl#48

Settings for Travis deploy

fix: use baseURL based on environment
Add BACKEND_API env var and use that as baseURL in services

Closes cribbl#43

[skip ci] Update readme

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

Feat: Post Event detail only description
Add dialog to take post event detail description

Relates cribbl#53

fix: Reduce maximum rooms allowed

Maximum rooms a club can book changed from 4 to 3

Closes cribbl#49

Fix: Reduce booking period to 20 days

The maximum date a club can book a room is reduced to 20 days from 1 month.

Closes cribbl#48

fix: Block some rooms for SC.

Block rooms in NLH first floor and 1 room(207) in AB5

fix: Disable editing club name abbrv
Club name abbreviation made non editable

Fix: Blunder of missing else
There was a missing else statement in after-signup

fix: change blocked rooms as per SC direction.

Summary of changes:

NLH:
`101,201,301,401` : These rooms are not available for booking and are
hence permanently deleted.
`202,203,204,205,304,305` : These rooms are reserved by SC
`302`: Reserved by Parikshit.

AB5
`207`: Reserved by SC.

fix: Temporarily block ground floor NLH rooms (booked for OEs)

Later rooms to be blocked according to the days on which they are
occupied.

fix: Unblock blocked rooms.

fix: Fixes bug caused by 2 rooms in AB5

AB5 310A and 310B weren't handled properly in the code. Treat them as
special cases.

style: Style fixes

fix: Change string to integer for 53101 and 53102

fix: Fix receipt URL bug on migration from AWS to firebase

Changed API endpoint of `sendEmailTemplate` to remove the hardcoded
firebase link and just send `event.key` instead.

Change case of SO by moving sendEmailTemplate after generatePDF

Change API of sendEmailTemplate

feat: Add admin page for Student Council.

Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (cribbl#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component

fix: Critical bug fix involving the room booking logic

This fixes the mysterious anonymous rooms in roomsx error.
For eg. Consider there is a booking for the 29th. Now when someone
books rooms from 28-30 the rooms for 29th will incorrectly be added to
the roomsx array for 28 and 30 also. This was caused because taken rooms
was calculated across all booking dates and then when roomsx was to be
updated the same array of takenRooms concatenated with selectedRooms was
used to update all dates.

fix: Remove duplicated room, AB5 505

fix: Update phone numbers

[NLH rooms] Disable 3202,3205

merge conf
Arushi1912 pushed a commit to Arushi1912/miteb-frontend that referenced this pull request Jan 18, 2019
fix: use baseURL based on environment
Add BACKEND_API env var and use that as baseURL in services

Closes cribbl#43

[skip ci] Update readme

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

Feat: Post Event detail only description
Add dialog to take post event detail description

Relates cribbl#53

fix: Reduce maximum rooms allowed

Maximum rooms a club can book changed from 4 to 3

Closes cribbl#49

Fix: Reduce booking period to 20 days

The maximum date a club can book a room is reduced to 20 days from 1 month.

Closes cribbl#48

Settings for Travis deploy

fix: use baseURL based on environment
Add BACKEND_API env var and use that as baseURL in services

Closes cribbl#43

[skip ci] Update readme

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

Feat: Post Event detail only description
Add dialog to take post event detail description

Relates cribbl#53

fix: Reduce maximum rooms allowed

Maximum rooms a club can book changed from 4 to 3

Closes cribbl#49

Fix: Reduce booking period to 20 days

The maximum date a club can book a room is reduced to 20 days from 1 month.

Closes cribbl#48

fix: Block some rooms for SC.

Block rooms in NLH first floor and 1 room(207) in AB5

fix: Disable editing club name abbrv
Club name abbreviation made non editable

Fix: Blunder of missing else
There was a missing else statement in after-signup

fix: change blocked rooms as per SC direction.

Summary of changes:

NLH:
`101,201,301,401` : These rooms are not available for booking and are
hence permanently deleted.
`202,203,204,205,304,305` : These rooms are reserved by SC
`302`: Reserved by Parikshit.

AB5
`207`: Reserved by SC.

fix: Temporarily block ground floor NLH rooms (booked for OEs)

Later rooms to be blocked according to the days on which they are
occupied.

fix: Unblock blocked rooms.

fix: Fixes bug caused by 2 rooms in AB5

AB5 310A and 310B weren't handled properly in the code. Treat them as
special cases.

style: Style fixes

fix: Change string to integer for 53101 and 53102

fix: Fix receipt URL bug on migration from AWS to firebase

Changed API endpoint of `sendEmailTemplate` to remove the hardcoded
firebase link and just send `event.key` instead.

Change case of SO by moving sendEmailTemplate after generatePDF

Change API of sendEmailTemplate

feat: Add admin page for Student Council.

Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (cribbl#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component

fix: Critical bug fix involving the room booking logic

This fixes the mysterious anonymous rooms in roomsx error.
For eg. Consider there is a booking for the 29th. Now when someone
books rooms from 28-30 the rooms for 29th will incorrectly be added to
the roomsx array for 28 and 30 also. This was caused because taken rooms
was calculated across all booking dates and then when roomsx was to be
updated the same array of takenRooms concatenated with selectedRooms was
used to update all dates.

fix: Remove duplicated room, AB5 505

fix: Update phone numbers

[NLH rooms] Disable 3202,3205

merge conf
Arushi1912 pushed a commit to Arushi1912/miteb-frontend that referenced this pull request Jan 21, 2019
… requests.

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

[InfoDesk] No. of desks, others

feat: Add admin page for Student Council.

Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (cribbl#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component

Final publicity

[dbServices] publicity node

others fix
Arushi1912 pushed a commit to Arushi1912/miteb-frontend that referenced this pull request Jan 21, 2019
[skip ci] Update readme

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

Feat: Post Event detail only description
Add dialog to take post event detail description

Relates cribbl#53

fix: Reduce maximum rooms allowed

Maximum rooms a club can book changed from 4 to 3

Closes cribbl#49

Fix: Reduce booking period to 20 days

The maximum date a club can book a room is reduced to 20 days from 1 month.

Closes cribbl#48

Settings for Travis deploy

fix: use baseURL based on environment
Add BACKEND_API env var and use that as baseURL in services

Closes cribbl#43

[skip ci] Update readme

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

fix: Reduce maximum rooms allowed

Maximum rooms a club can book changed from 4 to 3

Closes cribbl#49

Fix: Reduce booking period to 20 days

The maximum date a club can book a room is reduced to 20 days from 1 month.

Closes cribbl#48

fix: Block some rooms for SC.

Block rooms in NLH first floor and 1 room(207) in AB5

fix: Disable editing club name abbrv
Club name abbreviation made non editable

Fix: Blunder of missing else
There was a missing else statement in after-signup

fix: change blocked rooms as per SC direction.

Summary of changes:

NLH:
`101,201,301,401` : These rooms are not available for booking and are
hence permanently deleted.
`202,203,204,205,304,305` : These rooms are reserved by SC
`302`: Reserved by Parikshit.

AB5
`207`: Reserved by SC.

fix: Temporarily block ground floor NLH rooms (booked for OEs)

Later rooms to be blocked according to the days on which they are
occupied.

fix: Unblock blocked rooms.

fix: Fixes bug caused by 2 rooms in AB5

AB5 310A and 310B weren't handled properly in the code. Treat them as
special cases.

style: Style fixes

fix: Change string to integer for 53101 and 53102

fix: Fix receipt URL bug on migration from AWS to firebase

Changed API endpoint of `sendEmailTemplate` to remove the hardcoded
firebase link and just send `event.key` instead.

Change case of SO by moving sendEmailTemplate after generatePDF

Change API of sendEmailTemplate

feat: Add admin page for Student Council.

Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (cribbl#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component

fix: Critical bug fix involving the room booking logic

This fixes the mysterious anonymous rooms in roomsx error.
For eg. Consider there is a booking for the 29th. Now when someone
books rooms from 28-30 the rooms for 29th will incorrectly be added to
the roomsx array for 28 and 30 also. This was caused because taken rooms
was calculated across all booking dates and then when roomsx was to be
updated the same array of takenRooms concatenated with selectedRooms was
used to update all dates.

fix: Remove duplicated room, AB5 505

fix: Update phone numbers

[NLH rooms] Disable 3202,3205

[3202,3205] NLH rooms disabled

[Publicity Permissions] Fully functional feature for making publicity requests.

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

[InfoDesk] No. of desks, others

feat: Add admin page for Student Council.

Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (cribbl#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component

Final publicity

[dbServices] publicity node

others fix
Arushi1912 pushed a commit to Arushi1912/miteb-frontend that referenced this pull request Jan 21, 2019
…ermissions like posters, infodesks, etc.

[Publicity-UI] Permissions for publicity requests.

[skip ci] Update readme

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

Feat: Post Event detail only description
Add dialog to take post event detail description

Relates cribbl#53

fix: Reduce maximum rooms allowed

Maximum rooms a club can book changed from 4 to 3

Closes cribbl#49

Fix: Reduce booking period to 20 days

The maximum date a club can book a room is reduced to 20 days from 1 month.

Closes cribbl#48

Settings for Travis deploy

fix: use baseURL based on environment
Add BACKEND_API env var and use that as baseURL in services

Closes cribbl#43

[skip ci] Update readme

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

fix: Reduce maximum rooms allowed

Maximum rooms a club can book changed from 4 to 3

Closes cribbl#49

Fix: Reduce booking period to 20 days

The maximum date a club can book a room is reduced to 20 days from 1 month.

Closes cribbl#48

fix: Block some rooms for SC.

Block rooms in NLH first floor and 1 room(207) in AB5

fix: Disable editing club name abbrv
Club name abbreviation made non editable

Fix: Blunder of missing else
There was a missing else statement in after-signup

fix: change blocked rooms as per SC direction.

Summary of changes:

NLH:
`101,201,301,401` : These rooms are not available for booking and are
hence permanently deleted.
`202,203,204,205,304,305` : These rooms are reserved by SC
`302`: Reserved by Parikshit.

AB5
`207`: Reserved by SC.

fix: Temporarily block ground floor NLH rooms (booked for OEs)

Later rooms to be blocked according to the days on which they are
occupied.

fix: Unblock blocked rooms.

fix: Fixes bug caused by 2 rooms in AB5

AB5 310A and 310B weren't handled properly in the code. Treat them as
special cases.

style: Style fixes

fix: Change string to integer for 53101 and 53102

fix: Fix receipt URL bug on migration from AWS to firebase

Changed API endpoint of `sendEmailTemplate` to remove the hardcoded
firebase link and just send `event.key` instead.

Change case of SO by moving sendEmailTemplate after generatePDF

Change API of sendEmailTemplate

feat: Add admin page for Student Council.

Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (cribbl#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component

fix: Critical bug fix involving the room booking logic

This fixes the mysterious anonymous rooms in roomsx error.
For eg. Consider there is a booking for the 29th. Now when someone
books rooms from 28-30 the rooms for 29th will incorrectly be added to
the roomsx array for 28 and 30 also. This was caused because taken rooms
was calculated across all booking dates and then when roomsx was to be
updated the same array of takenRooms concatenated with selectedRooms was
used to update all dates.

fix: Remove duplicated room, AB5 505

fix: Update phone numbers

[NLH rooms] Disable 3202,3205

[3202,3205] NLH rooms disabled

[Publicity Permissions] Fully functional feature for making publicity requests.

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

[InfoDesk] No. of desks, others

feat: Add admin page for Student Council.

Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (cribbl#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component

Final publicity

[dbServices] publicity node

others fix
Arushi1912 pushed a commit to Arushi1912/miteb-frontend that referenced this pull request Jan 21, 2019
…ermissions like posters, infodesks, etc.

[Publicity-UI] Permissions for publicity requests.

[skip ci] Update readme

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

Feat: Post Event detail only description
Add dialog to take post event detail description

Relates cribbl#53

fix: Reduce maximum rooms allowed

Maximum rooms a club can book changed from 4 to 3

Closes cribbl#49

Fix: Reduce booking period to 20 days

The maximum date a club can book a room is reduced to 20 days from 1 month.

Closes cribbl#48

Settings for Travis deploy

fix: use baseURL based on environment
Add BACKEND_API env var and use that as baseURL in services

Closes cribbl#43

[skip ci] Update readme

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

fix: Reduce maximum rooms allowed

Maximum rooms a club can book changed from 4 to 3

Closes cribbl#49

Fix: Reduce booking period to 20 days

The maximum date a club can book a room is reduced to 20 days from 1 month.

Closes cribbl#48

fix: Block some rooms for SC.

Block rooms in NLH first floor and 1 room(207) in AB5

fix: Disable editing club name abbrv
Club name abbreviation made non editable

Fix: Blunder of missing else
There was a missing else statement in after-signup

fix: change blocked rooms as per SC direction.

Summary of changes:

NLH:
`101,201,301,401` : These rooms are not available for booking and are
hence permanently deleted.
`202,203,204,205,304,305` : These rooms are reserved by SC
`302`: Reserved by Parikshit.

AB5
`207`: Reserved by SC.

fix: Temporarily block ground floor NLH rooms (booked for OEs)

Later rooms to be blocked according to the days on which they are
occupied.

fix: Unblock blocked rooms.

fix: Fixes bug caused by 2 rooms in AB5

AB5 310A and 310B weren't handled properly in the code. Treat them as
special cases.

style: Style fixes

fix: Change string to integer for 53101 and 53102

fix: Fix receipt URL bug on migration from AWS to firebase

Changed API endpoint of `sendEmailTemplate` to remove the hardcoded
firebase link and just send `event.key` instead.

Change case of SO by moving sendEmailTemplate after generatePDF

Change API of sendEmailTemplate

feat: Add admin page for Student Council.

Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (cribbl#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component

fix: Critical bug fix involving the room booking logic

This fixes the mysterious anonymous rooms in roomsx error.
For eg. Consider there is a booking for the 29th. Now when someone
books rooms from 28-30 the rooms for 29th will incorrectly be added to
the roomsx array for 28 and 30 also. This was caused because taken rooms
was calculated across all booking dates and then when roomsx was to be
updated the same array of takenRooms concatenated with selectedRooms was
used to update all dates.

fix: Remove duplicated room, AB5 505

fix: Update phone numbers

[NLH rooms] Disable 3202,3205

[3202,3205] NLH rooms disabled

[Publicity Permissions] Fully functional feature for making publicity requests.

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

[InfoDesk] No. of desks, others

feat: Add admin page for Student Council.

Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (cribbl#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component

Final publicity

[dbServices] publicity node

others fix

fix: use baseURL based on environment
Add BACKEND_API env var and use that as baseURL in services

Closes cribbl#43

[skip ci] Update readme

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

Feat: Post Event detail only description
Add dialog to take post event detail description

Relates cribbl#53

fix: Reduce maximum rooms allowed

Maximum rooms a club can book changed from 4 to 3

Closes cribbl#49

Fix: Reduce booking period to 20 days

The maximum date a club can book a room is reduced to 20 days from 1 month.

Closes cribbl#48

fix: use baseURL based on environment
Add BACKEND_API env var and use that as baseURL in services

Closes cribbl#43

[skip ci] Update readme

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

Feat: Post Event detail only description
Add dialog to take post event detail description

Relates cribbl#53

fix: Reduce maximum rooms allowed

Maximum rooms a club can book changed from 4 to 3

Closes cribbl#49

Fix: Reduce booking period to 20 days

The maximum date a club can book a room is reduced to 20 days from 1 month.

Closes cribbl#48

fix: Block some rooms for SC.

Block rooms in NLH first floor and 1 room(207) in AB5

fix: Disable editing club name abbrv
Club name abbreviation made non editable

Fix: Blunder of missing else
There was a missing else statement in after-signup

fix: Temporarily block ground floor NLH rooms (booked for OEs)

Later rooms to be blocked according to the days on which they are
occupied.

fix: Unblock blocked rooms.

fix: Change string to integer for 53101 and 53102

fix: Fix receipt URL bug on migration from AWS to firebase

Changed API endpoint of `sendEmailTemplate` to remove the hardcoded
firebase link and just send `event.key` instead.

Change case of SO by moving sendEmailTemplate after generatePDF

Change API of sendEmailTemplate

feat: Add admin page for Student Council.

Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (cribbl#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component

fix: Critical bug fix involving the room booking logic

This fixes the mysterious anonymous rooms in roomsx error.
For eg. Consider there is a booking for the 29th. Now when someone
books rooms from 28-30 the rooms for 29th will incorrectly be added to
the roomsx array for 28 and 30 also. This was caused because taken rooms
was calculated across all booking dates and then when roomsx was to be
updated the same array of takenRooms concatenated with selectedRooms was
used to update all dates.

fix: Remove duplicated room, AB5 505

fix: Update phone numbers

[NLH rooms] Disable 3202,3205

[3202,3205] NLH rooms disabled

duplicate bookings
Arushi1912 pushed a commit to Arushi1912/miteb-frontend that referenced this pull request Jan 22, 2019
Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (cribbl#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component
Arushi1912 pushed a commit to Arushi1912/miteb-frontend that referenced this pull request Jan 22, 2019
… permissions

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

fix: Block some rooms for SC.

Block rooms in NLH first floor and 1 room(207) in AB5

feat: Add admin page for Student Council.

Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (cribbl#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component

[3202,3205] NLH rooms disabled

Standard

fix: use baseURL based on environment
Add BACKEND_API env var and use that as baseURL in services

Closes cribbl#43

[skip ci] Update readme

Feat: Actions on events by SC

Allow SC to approve/reject/flag an event before FA, AD, SO

Closes cribbl#50

fix: standardise start_date, end_date

Use camelCase => startDate, endDate

Feat: Post Event detail only description
Add dialog to take post event detail description

Relates cribbl#53

fix: Reduce maximum rooms allowed

Maximum rooms a club can book changed from 4 to 3

Closes cribbl#49

Fix: Reduce booking period to 20 days

The maximum date a club can book a room is reduced to 20 days from 1 month.

Closes cribbl#48

fix: Block some rooms for SC.

Block rooms in NLH first floor and 1 room(207) in AB5

fix: Disable editing club name abbrv
Club name abbreviation made non editable

Fix: Blunder of missing else
There was a missing else statement in after-signup

fix: Temporarily block ground floor NLH rooms (booked for OEs)

Later rooms to be blocked according to the days on which they are
occupied.

fix: Unblock blocked rooms.

fix: Change string to integer for 53101 and 53102

fix: Fix receipt URL bug on migration from AWS to firebase

Changed API endpoint of `sendEmailTemplate` to remove the hardcoded
firebase link and just send `event.key` instead.

Change case of SO by moving sendEmailTemplate after generatePDF

Change API of sendEmailTemplate

feat: Add admin page for Student Council.

Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (cribbl#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component

fix: Critical bug fix involving the room booking logic

This fixes the mysterious anonymous rooms in roomsx error.
For eg. Consider there is a booking for the 29th. Now when someone
books rooms from 28-30 the rooms for 29th will incorrectly be added to
the roomsx array for 28 and 30 also. This was caused because taken rooms
was calculated across all booking dates and then when roomsx was to be
updated the same array of takenRooms concatenated with selectedRooms was
used to update all dates.

fix: Remove duplicated room, AB5 505

fix: Update phone numbers

[3202,3205] NLH rooms disabled

0 code
dheeraj-coding pushed a commit to dheeraj-coding/miteb-frontend that referenced this pull request Mar 15, 2019
Student Council requires to keep track of which rooms are occupied by
which club so that they can control the room bookings. This feature
helps achieve the Council to get information regarding which event is
going to be held at a particular room at a particular day.

feat: Additional feature requests by SC on View Bookings (cribbl#69)

* Add error message if no event is found

* Allow Operations to access View Bookings page

Change name from ViewBookings to ViewBookings component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant