Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang dependencies #7294

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind dependency-change

What this PR does / why we need it:

Updating the latest golang dependencies.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies labels Sep 11, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@saschagrunert saschagrunert changed the title Bump golang dependencies WIP: Bump golang dependencies Sep 11, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2023
@saschagrunert
Copy link
Member Author

Needs containers/conmon-rs#1683

@saschagrunert saschagrunert changed the title WIP: Bump golang dependencies Bump golang dependencies Sep 13, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #7294 (37b75a6) into main (8ac8c66) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7294   +/-   ##
=======================================
  Coverage   49.22%   49.23%           
=======================================
  Files         136      136           
  Lines       15648    15648           
=======================================
+ Hits         7703     7704    +1     
+ Misses       7029     7028    -1     
  Partials      916      916           

@saschagrunert
Copy link
Member Author

/retest

6 similar comments
@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/retest

@sohankunkerkar
Copy link
Member

/retest

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/override ci/prow/images
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-aws-ovn, ci/prow/e2e-gcp-ovn, ci/prow/images

In response to this:

/override ci/prow/images
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member Author

@sohankunkerkar @cri-o/cri-o-maintainers PTAL

Copy link
Member

@sohankunkerkar sohankunkerkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member Author

/test ci-rhel-critest

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-rhel-critest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-rhel-critest

In response to this:

/override ci/prow/ci-rhel-critest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-gcp-ovn

@saschagrunert
Copy link
Member Author

/test images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-aws-ovn, ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2023
@saschagrunert
Copy link
Member Author

saschagrunert commented Sep 18, 2023

@sohankunkerkar can we bump the golang version in the images test:

# github.com/containers/conmon-rs/pkg/client
vendor/github.com/containers/conmon-rs/pkg/client/attach.go:406:18: undefined: errors.Join
vendor/github.com/containers/conmon-rs/pkg/client/attach.go:431:19: undefined: errors.Join
note: module requires Go 1.20

Proposing that in openshift/release#43440

Signed-off-by: Sascha Grunert <[email protected]>
@sohankunkerkar
Copy link
Member

/retest

@saschagrunert
Copy link
Member Author

/override ci/prow/e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sohankunkerkar
Copy link
Member

Let's get this PR in, and then we can bump containers/storage to v1.50.2

@sohankunkerkar
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@sohankunkerkar
Copy link
Member

/retest

github.com/containers/image/v5 v5.27.0
github.com/containers/kubensmnt v1.2.0
github.com/containers/ocicrypt v1.1.8
github.com/containers/podman/v4 v4.6.2
github.com/containers/storage v1.49.0
github.com/containers/storage v1.50.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
github.com/containers/storage v1.50.0
github.com/containers/storage v1.50.2

I wanted to bump this up in #7313 but you already had this PR up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's follow-up on this, the PR almost got it through CI already.

@saschagrunert
Copy link
Member Author

/override ci/prow/ci-e2e-evented-pleg

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

@saschagrunert: Overrode contexts on behalf of saschagrunert: ci/prow/ci-e2e-evented-pleg

In response to this:

/override ci/prow/ci-e2e-evented-pleg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 929d76e into cri-o:main Sep 20, 2023
42 of 43 checks passed
@saschagrunert saschagrunert deleted the deps branch September 20, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants