Fix constant int overflow for GOARCH=386
#1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing the build for: ``` > GOARCH=386 go build ./... pkg/client/remote_fds.go:101:15: invalid operation: numFDs == int64(1) << int64(numFDsBits) (mismatched types int and int64) ``` Signed-off-by: Sascha Grunert <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Sep 11, 2023
Merged
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
==========================================
+ Coverage 34.92% 35.62% +0.69%
==========================================
Files 13 13
Lines 1151 1151
Branches 370 370
==========================================
+ Hits 402 410 +8
+ Misses 520 505 -15
- Partials 229 236 +7 |
|
@rphillips @haircommander PTAL |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixing the build for:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?