ci-verify: Run get-scripts only on main branch #6514
Conversation
This change adjusts the get-script and get-script-with-verification jobs to only run for PRs where the target branch is `main`, so that release branches do not fail with the latest configuration. Closes cri-o#6512 Signed-off-by: Jose Valdes <[email protected]>
openshift-ci
bot
added
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
dco-signoff: yes
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/cherry-pick release-1.26 |
|
@jrvaldes: once the present PR merges, I will cherry-pick it on top of release-1.26 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6514 +/- ##
==========================================
+ Coverage 42.48% 42.49% +0.01%
==========================================
Files 128 128
Lines 14943 14943
==========================================
+ Hits 6348 6350 +2
+ Misses 7904 7903 -1
+ Partials 691 690 -1 |
|
/retest-required |
|
@cri-o/cri-o-maintainers PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrvaldes, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@jrvaldes: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
@haircommander: Overrode contexts on behalf of haircommander: ci/kata-jenkins, ci/prow/ci-e2e-conmonrs, ci/prow/ci-rhel-integration In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is there a known issue? I have mixed feelings overriding required jobs, it may be an indication that they may not be required at all 😸 |
|
FWIW: ci-rhel-integration and ci-e2e-conmonrs aren't required, but the bot is kind of treating them as such |
@haircommander looks like the bot did not liked the override for the following jobs. PTAL.
|
|
/override ci/prow/ci-e2e-conmonrs |
|
@haircommander: Overrode contexts on behalf of haircommander: ci/prow/ci-e2e-conmonrs, ci/prow/ci-rhel-integration In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jrvaldes: new pull request created: #6525 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind ci
What this PR does / why we need it:
This change adjusts the get-script and get-script-with-verification jobs to only run for PRs where the target branch is main, so that release branches do not fail with the latest configuration.
Which issue(s) this PR fixes:
Closes #6512
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
None