Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get-script and get-script-with-verification CI jobs fail in release branches #6512

Closed
jrvaldes opened this issue Jan 10, 2023 · 0 comments · Fixed by #6514
Closed

get-script and get-script-with-verification CI jobs fail in release branches #6512

jrvaldes opened this issue Jan 10, 2023 · 0 comments · Fixed by #6514
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.

Comments

@jrvaldes
Copy link
Contributor

Which jobs are failing?

The get-script and get-script-with-verification CI jobs fail in release branches with:

install: cannot stat 'contrib/10-crio-bridge.conf': No such file or directory

Link of failed jobs instances:
https://github.com/cri-o/cri-o/actions/runs/3877439334/jobs/6612456187

https://github.com/cri-o/cri-o/actions/runs/3877439334/jobs/6612456278

Which tests are failing?

get-script:
https://github.com/cri-o/cri-o/blob/main/.github/workflows/verify.yml#L99

get-script-with-verification:
https://github.com/cri-o/cri-o/blob/main/.github/workflows/verify.yml#L106

Since when has it been failing?

Since #6289 merged.

Testgrid link

No response

Reason for failure (if possible)

The script testing should not be pulling in latest main when being tested on release branches.

Anything else we need to know?

The get-script and get-script-with-verification CI jobs should only run if the PR targets the main branch.
@jrvaldes jrvaldes added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jan 10, 2023
jrvaldes added a commit to jrvaldes/cri-o that referenced this issue Jan 10, 2023
@jrvaldes
ci-verify: Run get-scripts only on main branch
faeaced 
This change adjusts the get-script and get-script-with-verification jobs
to only run for PRs where the target branch is `main`, so that release
branches do not fail with the latest configuration.

Closes cri-o#6512

Signed-off-by: Jose Valdes <[email protected]>
@jrvaldes jrvaldes mentioned this issue Jan 10, 2023
Merged
@jefflill jefflill mentioned this issue Jan 10, 2023
Closed
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/cri-o that referenced this issue Jan 11, 2023
@jrvaldes
ci-verify: Run get-scripts only on main branch
5ce93c6 
This change adjusts the get-script and get-script-with-verification jobs
to only run for PRs where the target branch is `main`, so that release
branches do not fail with the latest configuration.

Closes cri-o#6512

Signed-off-by: Jose Valdes <[email protected]>
@jrvaldes jrvaldes mentioned this issue Jan 11, 2023
Merged
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/cri-o that referenced this issue Jan 12, 2023
@jrvaldes
ci-verify: Run get-scripts only on main branch
dfff7e6 
This change adjusts the get-script and get-script-with-verification jobs
to only run for PRs where the target branch is `main`, so that release
branches do not fail with the latest configuration.

Closes cri-o#6512

Signed-off-by: Jose Valdes <[email protected]>
@jrvaldes jrvaldes mentioned this issue Jan 12, 2023
Merged
jrvaldes added a commit to jrvaldes/cri-o that referenced this issue Jan 16, 2023
@jrvaldes
ci-verify: Run get-scripts only on main branch
03b1690 
This change adjusts the get-script job
to only run for PRs where the target branch is `main`, so that release
branches do not fail with the latest configuration.

Closes cri-o#6512

Signed-off-by: Jose Valdes <[email protected]>
(cherry picked from commit dfff7e6)
@jrvaldes jrvaldes mentioned this issue Jan 16, 2023
Merged
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/cri-o that referenced this issue Jan 19, 2023
@jrvaldes
ci-verify: Run get-scripts only on main branch
6d143c8 
This change adjusts the get-script job
to only run for PRs where the target branch is `main`, so that release
branches do not fail with the latest configuration.

Closes cri-o#6512

Signed-off-by: Jose Valdes <[email protected]>
(cherry picked from commit dfff7e6)
n4j pushed a commit to n4j/cri-o that referenced this issue Feb 17, 2023
@jrvaldes @n4j
ci-verify: Run get-scripts only on main branch
c149061 
This change adjusts the get-script and get-script-with-verification jobs
to only run for PRs where the target branch is `main`, so that release
branches do not fail with the latest configuration.

Closes cri-o#6512

Signed-off-by: Jose Valdes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci-verify: Run get-scripts only on main branch jrvaldes/cri-o
1 participant
@jrvaldes