Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #37 [BUG] Dry run reporting unpretty files when all files match styles #46

Merged
merged 11 commits into from
Apr 10, 2021
Merged

Fixes Issue #37 [BUG] Dry run reporting unpretty files when all files match styles #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b40e4ba
fix(issue-37): adds logic to handle prettier cmd output to shell dry-…
fsz-codeshop Mar 25, 2021
0e4ccc8
style: fixes log message
fsz-codeshop Mar 25, 2021
217be60
fix: removes code block added by mistake from dev branch
fsz-codeshop Mar 25, 2021
70f47fb
fix: fixes handling of bad case where there are unpretty files and co…
fsz-codeshop Mar 25, 2021
341259c
other: testing another approach to handle both cases
fsz-codeshop Mar 25, 2021
2602a7a
other: testing approach using pipefail
fsz-codeshop Mar 26, 2021
67234be
other: testing approach with multiple commands on fail
fsz-codeshop Mar 26, 2021
3d912f6
fix: added variable declaration
fsz-codeshop Mar 26, 2021
5b4a6a0
docs: note about using --check on options to help in dry running
fsz-codeshop Mar 26, 2021
2069f26
other: improves the log output by not having and out of range message
fsz-codeshop Mar 26, 2021
c2e2730
fix: fixes codefactor recommendation
fsz-codeshop Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ A GitHub action for styling files with [prettier](https://prettier.io).

| Parameter | Required | Default | Description |
| - | :-: | :-: | - |
| dry | :x: | `false` | Runs the action in dry mode. Files wont get changed and the action fails if there are unprettified files. |
| dry | :x: | `false` | Runs the action in dry mode. Files wont get changed and the action fails if there are unprettified files. Recommended to use with prettier_options --check |
| prettier_version | :x: | `false` | Specific prettier version (by default use latest) |
| prettier_options | :x: | `"--write **/*.js"` | Prettier options (by default it applies to the whole repository) |
| commit_options | :x: | - | Custom git commit options |
Expand Down
13 changes: 9 additions & 4 deletions entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,20 @@ if [ -n "$INPUT_PRETTIER_PLUGINS" ]; then
npm install --silent --global $INPUT_PRETTIER_PLUGINS
fi

echo "Prettifing files..."
PRETTIER_RESULT=0
echo "Prettifying files..."
echo "Files:"
prettier $INPUT_PRETTIER_OPTIONS || echo "Problem running prettier with $INPUT_PRETTIER_OPTIONS"
prettier $INPUT_PRETTIER_OPTIONS || { PRETTIER_RESULT=$?; echo "Problem running prettier with $INPUT_PRETTIER_OPTIONS"; }

# To keep runtime good, just continue if something was changed
if _git_changed; then
if $INPUT_DRY; then
echo "Prettier found unpretty files!"
exit 1
if [ "$PRETTIER_RESULT" -eq 1 ]; then
echo "Prettier found unpretty files!"
exit 1
else
echo "No unpretty files! Finishing dry-run."
fi
else
# Calling method to configure the git environemnt
_git_setup
Expand Down