Fixes Issue #37 [BUG] Dry run reporting unpretty files when all files match styles #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmand output is not 0
|
hey folks, is this going to be checked/reviewed soon? ( no mean to rush, just asking as I am having the same issue and just wanted to know if I need to switch to my own action ) |
|
@brussev Not sure if it helps but meanwhile I am running with in case you might wanna try it out. |
Yes, sorry for the delay, I will take a look at this! |
creyD
added a commit
that referenced
this pull request
May 21, 2021
…npretty Fixes Issues from PR #46 (37 [BUG] Dry run reporting unpretty files when all files match styles)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #37 [BUG] Dry run reporting unpretty files when all files match styles by adding a verification of shell command output for prettier and verifying it status code in case it is a dry-run, handling it properly.