Add podman-remote binary to bundle #378

guillaumerose · 2021-03-30T10:01:04Z

The podman client exactly matches the podman version of the server.
It replicates what we do with oc.

praveenkumar · 2021-03-30T10:36:12Z

createdisk-library.sh

+
+    mkdir -p podman-remote/linux
+    curl -L https://github.com/containers/podman/releases/download/v${version}/podman-remote-static.tar.gz | tar -zx -C podman-remote/linux podman-remote-static
+    mv podman-remote/linux/podman-remote-static podman-remote/linux/podman


Should we say podman-remote or podman for the binary (all the platform)? Release page have podman-remote name for all the release artifacts.

Yes good question. The macOS and Windows packages contain podman directly, not podman-remote.

podman and podman-remote are 2 different binaries, so let's keep the podman-remote name, naming it podman is going to be confusing.

$ sha256sum /usr/bin/podman* c553c90f4268fa2e01be30361b24367a977f555a7a25b188e8f4bb0d31927012 /usr/bin/podman 5b057ddde34128594580f216b2c36d5eb710a872c442159ee7156a4eba5377bb /usr/bin/podman-remote

changed 👍

This was part of a discussion that Dan Walsh had strong opinions about. He didn't allow at that time to call the binary podman as that is NOT what it is.

This PR is now using the same name as the upstream tarballs, they can fix that naming if it's wrong and we'll follow suit, but I don't think we should block this PR on this?

Windows: https://github.com/containers/podman/releases/download/v3.0.0/podman-remote-release-windows.zip -> podman.exe

macOS: https://github.com/containers/podman/releases/download/v3.0.0/podman-remote-release-darwin.zip -> podman

linux: https://github.com/containers/podman/releases/download/v3.0.0/podman-remote-static.tar.gz -> podman-remote (rather than podman-remote-static)

3.1.0 was released yesterday, but has no builds, https://github.com/containers/podman/releases/tag/v3.1.0 hopefully they'll be coming later.

praveenkumar · 2021-03-30T10:36:52Z

/retest

gbraad

/onhold

Binary name is under discussion

guillaumerose · 2021-04-12T06:36:55Z

/retest

praveenkumar · 2021-04-14T07:36:04Z

as per https://github.com/containers/podman/pull/9381/files#diff-7e8ec8aae93ed3672946c8150f80f18d724d50ee1dfff70230f3b7c6d3f4f423R9-R19 looks like they are going with podman (for win and mac) and podman-remote for linux so this PR make sense.

/lgtm

praveenkumar · 2021-04-14T07:38:09Z

/hold cancel

praveenkumar · 2021-04-14T07:38:59Z

/cherry-pick 4.7

openshift-cherrypick-robot · 2021-04-14T07:39:00Z

@praveenkumar: once the present PR merges, I will cherry-pick it on top of 4.7 in a new PR and assign it to you.

In response to this:

/cherry-pick 4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

praveenkumar · 2021-04-14T07:40:03Z

/unhold

gbraad · 2021-04-14T07:40:39Z

When adding the functionality to the podman-env command, we need to make sure the summary is given. And also make sure we accordingly document this

…

On Wed, Apr 14, 2021 at 3:39 PM OpenShift Cherrypick Robot < ***@***.***> wrote: @praveenkumar <https://github.com/praveenkumar>: once the present PR merges, I will cherry-pick it on top of 4.7 in a new PR and assign it to you. In response to this <#378 (comment)>: /cherry-pick 4.7 Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#378 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAOZSFZGOP44HB465KLO3TIVBCHANCNFSM42BVUGDQ> .

-- Gerard Braad | http://gbraad.nl STEM is the source, but BUILD is how you develop! [ Better Understanding Involves Learning and Doing ]

cfergeau · 2021-04-14T07:44:14Z

createdisk-library.sh

+
+    if [ -n "${SNC_GENERATE_MACOS_BUNDLE}" ]; then
+      mkdir -p podman-remote/mac
+      curl -L https://github.com/containers/podman/releases/download/v${version}/podman-remote-release-darwin.zip > podman-remote/mac/podman.zip


this could use curl -O -L instead of > podman-remote/mac/podman.zip

cfergeau

Looks good to me!

cfergeau · 2021-04-14T07:45:22Z

Maybe add this:

$ git diff
diff --git a/crc-bundle-info.json.sample b/crc-bundle-info.json.sample
index 1281c6a..a5d0d95 100644
--- a/crc-bundle-info.json.sample
+++ b/crc-bundle-info.json.sample
@@ -82,7 +82,7 @@
       {
         # Name of the file
        "name": "oc"
-       # What kind of file this is, valid types are 'oc-executable'
+       # What kind of file this is, valid types are 'oc-executable', 'podman-executable'
        "type": "oc-executable"
        "size": "72728632"
        "sha256sum": "983f0883a6dffd601afa663d10161bfd8033fd6d45cf587a9cb22e9a681d6047"

The podman client exactly matches the podman version of the server. It replicates what we do with oc.

openshift-ci-robot · 2021-04-14T09:06:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, guillaumerose

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cfergeau,guillaumerose]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

guillaumerose · 2021-04-14T12:17:16Z

conformance tests unhappy

/retest

openshift-cherrypick-robot · 2021-04-14T17:45:57Z

@praveenkumar: new pull request created: #394

In response to this:

/cherry-pick 4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This new type was added by crc-org/snc#378

openshift-ci-robot requested review from anjannath and cfergeau March 30, 2021 10:01

openshift-ci-robot added the approved label Mar 30, 2021

praveenkumar reviewed Mar 30, 2021

View reviewed changes

guillaumerose force-pushed the addpodmanremote branch from f2eeb80 to 1afe52d Compare March 30, 2021 11:45

cfergeau approved these changes Mar 30, 2021

View reviewed changes

openshift-ci-robot assigned cfergeau Mar 30, 2021

openshift-ci-robot added the lgtm label Mar 30, 2021

gbraad requested changes Mar 31, 2021

View reviewed changes

openshift-ci-robot added the do-not-merge/hold label Mar 31, 2021

openshift-ci-robot assigned gbraad Mar 31, 2021

openshift-ci-robot removed the lgtm label Mar 31, 2021

gbraad mentioned this pull request Mar 31, 2021

podman binary name crc-org/crc#2171

Closed

openshift-ci-robot added the needs-rebase label Apr 11, 2021

guillaumerose force-pushed the addpodmanremote branch from 1afe52d to fc9ed3e Compare April 11, 2021 19:45

openshift-ci-robot removed the needs-rebase label Apr 11, 2021

openshift-ci-robot assigned praveenkumar Apr 14, 2021

openshift-ci-robot added the lgtm label Apr 14, 2021

openshift-ci-robot removed the do-not-merge/hold label Apr 14, 2021

cfergeau reviewed Apr 14, 2021

View reviewed changes

cfergeau approved these changes Apr 14, 2021

View reviewed changes

guillaumerose force-pushed the addpodmanremote branch from fc9ed3e to c0c9cfa Compare April 14, 2021 08:57

openshift-ci-robot removed the lgtm label Apr 14, 2021

Add podman-remote binary to bundle

7c3f6d1

The podman client exactly matches the podman version of the server. It replicates what we do with oc.

guillaumerose force-pushed the addpodmanremote branch from c0c9cfa to 7c3f6d1 Compare April 14, 2021 09:05

cfergeau approved these changes Apr 14, 2021

View reviewed changes

openshift-ci-robot added the lgtm label Apr 14, 2021

guillaumerose merged commit 9a70944 into crc-org:master Apr 14, 2021

openshift-cherrypick-robot mentioned this pull request Apr 14, 2021

[4.7] Add podman-remote binary to bundle #394

Merged

guillaumerose added a commit to guillaumerose/crc that referenced this pull request Apr 16, 2021

Add podman-executable type in metadata struct

e8173d4

This new type was added by crc-org/snc#378

guillaumerose added a commit to guillaumerose/crc that referenced this pull request Apr 19, 2021

Add podman-executable type in metadata struct

a4efc95

This new type was added by crc-org/snc#378

guillaumerose added a commit to guillaumerose/crc that referenced this pull request Apr 26, 2021

Add podman-executable type in metadata struct

24370bf

This new type was added by crc-org/snc#378

praveenkumar pushed a commit to crc-org/crc that referenced this pull request Apr 27, 2021

Add podman-executable type in metadata struct

fbaf2ad

This new type was added by crc-org/snc#378

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add podman-remote binary to bundle #378

Add podman-remote binary to bundle #378

guillaumerose commented Mar 30, 2021 •

edited

Loading

praveenkumar Mar 30, 2021

guillaumerose Mar 30, 2021

cfergeau Mar 30, 2021

guillaumerose Mar 30, 2021

gbraad Mar 31, 2021

cfergeau Mar 31, 2021

cfergeau Mar 31, 2021

praveenkumar commented Mar 30, 2021

gbraad left a comment •

edited

Loading

guillaumerose commented Apr 12, 2021

praveenkumar commented Apr 14, 2021

praveenkumar commented Apr 14, 2021

praveenkumar commented Apr 14, 2021

openshift-cherrypick-robot commented Apr 14, 2021

praveenkumar commented Apr 14, 2021

gbraad commented Apr 14, 2021 via email

cfergeau Apr 14, 2021

cfergeau left a comment

cfergeau commented Apr 14, 2021

openshift-ci-robot commented Apr 14, 2021

guillaumerose commented Apr 14, 2021

openshift-cherrypick-robot commented Apr 14, 2021

Add podman-remote binary to bundle #378

Add podman-remote binary to bundle #378

Conversation

guillaumerose commented Mar 30, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

praveenkumar commented Mar 30, 2021

gbraad left a comment • edited Loading

Choose a reason for hiding this comment

guillaumerose commented Apr 12, 2021

praveenkumar commented Apr 14, 2021

praveenkumar commented Apr 14, 2021

praveenkumar commented Apr 14, 2021

openshift-cherrypick-robot commented Apr 14, 2021

praveenkumar commented Apr 14, 2021

gbraad commented Apr 14, 2021 via email

Choose a reason for hiding this comment

cfergeau left a comment

Choose a reason for hiding this comment

cfergeau commented Apr 14, 2021

openshift-ci-robot commented Apr 14, 2021

guillaumerose commented Apr 14, 2021

openshift-cherrypick-robot commented Apr 14, 2021

guillaumerose commented Mar 30, 2021 •

edited

Loading

gbraad left a comment •

edited

Loading