Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman binary name #2171

Closed
gbraad opened this issue Mar 31, 2021 · 10 comments
Closed

podman binary name #2171

gbraad opened this issue Mar 31, 2021 · 10 comments
Labels
kind/bug Something isn't working

Comments

@gbraad
Copy link
Contributor

gbraad commented Mar 31, 2021

The inclusion of the podman client is very inconsistent; as for Linux this can be the full implementation, while on macOS/Windows this is podman-remote.

When considering convenience and consistent use we want to settle on a single command; podman. This has been brought up before.

crc-org/snc#378

@gbraad gbraad added the kind/bug Something isn't working label Mar 31, 2021
@gbraad
Copy link
Contributor Author

gbraad commented Mar 31, 2021

/cc: @fatherlinux, @baude, WDYT?

@gbraad gbraad changed the title [BUG] podman binary name Mar 31, 2021
@gbraad
Copy link
Contributor Author

gbraad commented Mar 31, 2021

We will use podman-remote as according to our @code-ready/crc-team sync-up

@cfergeau
Copy link
Contributor

Is there an upstream issue regarding the inconsistent naming?

@cfergeau cfergeau reopened this Mar 31, 2021
@gbraad
Copy link
Contributor Author

gbraad commented Mar 31, 2021

@cfergeau this is what I could find containers/podman#5477 (comment) and there has been an email conversation around this.

@gbraad
Copy link
Contributor Author

gbraad commented Mar 31, 2021

The interesting reply is: containers/podman#5477 (comment)


@rhatdan wrote:
Yes I agree, the executable should be podman.exe not podman-remote-windows.exe


The V2.2.1 releases are:

So there is still an inconsistency between what the platforms provide as binary/command for inclusion. From our perspective a single option should be given, as else this needs to be documented differently for the platforms. Some of these specifics can be found in the bundle inclusion code: https://github.com/code-ready/snc/pull/378/files#diff-95795afe77d69420567b1e1e44ff75e9dd179f9caaaa51eefa0581e1fc1067f0

My biggest concern is around how this experience will be to the user when they use the podman-env command and how to document this. On Windows we use podman.exe, but on Linux podman-remote to prevent a possible conflict with the current installed version?

@guillaumerose
Copy link
Contributor

containers/podman#9918 confirms what I have in crc-org/snc#378

Linux: podman-remote
macOS: podman
Windows: podman.exe

@gbraad
Copy link
Contributor Author

gbraad commented Apr 2, 2021

While correct what @vrothberg concludes, this would lead to an inconsistency for use on #Linux if we expose this as a command.

podman-env would add to path, and would have to instruct the user based on the OS to either use podman or podman-remote, and this also needs to be documented accordingly. To me this feels like a bad UX.

Note: In our case we are always performing a remote session, while NOT as nice a command, it would be consistent to use podman-remote. Also, you can't assume a podman command to exist on Linux is the user might not have installed this (and if he did, why would he use crc)? So, do we really care about a command clash?

@gbraad
Copy link
Contributor Author

gbraad commented Apr 8, 2021

containers/podman#9381

@cevich
Copy link

cevich commented Apr 8, 2021

#9381 is almost ready, doing final testing and tweaking now.

@guillaumerose
Copy link
Contributor

In 1.26.0:
Linux: podman-remote
macOS: podman
Windows: podman.exe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants