Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quote_relation_name support utility function #155

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Aug 27, 2024

About

The quote_relation_name support utility function is required in other packages than cratedb-toolkit. Because cratedb-toolkit is too heavy to be pulled into smaller packages, let's break it out of it.

References

/cc @wierdvanderhaar, @hlcianfagna, @karynzv, @juanpardo, @tomach, @Taliik, @proddata

@amotl amotl requested review from matriv and surister August 27, 2024 20:04
@amotl amotl marked this pull request as ready for review August 27, 2024 20:06
@amotl amotl force-pushed the amo/support-table-quoting branch 2 times, most recently from 4ac3451 to b1e4e37 Compare August 27, 2024 20:12
@amotl amotl force-pushed the amo/support-table-quoting branch from b1e4e37 to fab6f4b Compare August 27, 2024 22:26
@amotl amotl requested a review from proddata August 27, 2024 22:42
@amotl amotl force-pushed the amo/support-table-quoting branch from fab6f4b to a80fb4d Compare August 28, 2024 06:59
@amotl amotl force-pushed the amo/support-table-quoting branch from a80fb4d to 99ee4cc Compare August 28, 2024 09:53
@amotl amotl requested review from seut, matriv and proddata and removed request for matriv, surister and proddata August 29, 2024 13:09
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

Some more info, but I don't think it's necessary for the purpose of this PR:
In CrateDB, we use some extra checks to judge if quoting is necessary: https://github.com/crate/crate/blob/master/libs/sql-parser/src/main/java/io/crate/sql/Identifiers.java#L88

@amotl amotl merged commit e17ba04 into main Aug 29, 2024
27 checks passed
@amotl amotl deleted the amo/support-table-quoting branch August 29, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants