Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMS/DynamoDB: Fix table name quoting within CDC processor handler #245

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Aug 27, 2024

About

Easily fix missing table quoting within CDC processor for DMS and DynamoDB events. It will need more improvements by adding the canonical implementation quote_relation_name to sqlalchemy-cratedb, but may be good for now.

@amotl amotl marked this pull request as ready for review August 27, 2024 09:38
# FIXME: Needs proper table name quoting.
connection.execute(sa.text(f"REFRESH TABLE {CRATEDB_TABLE}"))
connection.execute(sa.text(f"REFRESH TABLE {cdc.quote_table_name(CRATEDB_TABLE)}"))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See quote_table_name. It is currently just a poor man's version until we can shuffle code better and more sustainably.

Copy link

@wierdvanderhaar wierdvanderhaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go!

@amotl amotl merged commit 60fc24f into main Aug 27, 2024
13 checks passed
@amotl amotl deleted the dynamodb-table-quoting branch August 27, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants