Unlinking a link and then inserting it again removes other links

[ai5679]

Description

Unlinking a link and then inserting it again removes other links in a paragraph.

Steps to reproduce

1. Unlink a link
2. Insert the link again
3. The link earlier in the text disappears.

Screen recording of the issue: https://jmp.sh/9jOwd97

Additional info

• Redactor version: 2.10.3

[umkasanki]

We have same issue

[corneliusio]

Our team has also been experiencing this on a client site, but even without having first unlinked another link. From what I can tell these are the specific factors that seem to be at play.

1. Only seems to occur when linking an entry, asset, or category. Inserting a custom URL does not appear to be causing this.
2. If the text being link proceeds all other links in the field, the link is inserted as expected.
3. If the first item is true and the text being linked follows any other links, the immediately preceding link is overwritten with both the URL and text being defined for the new link, leaving the original text intended to be linked unchanged.

There seems to be something occurring with the loss of focus on the input field when the Craft CMS modal for selecting entries opens, when the input is refocused after an entry is selected, the selection area of the text appears to jump to the preceding link and overwrite it instead of inserting the new anchor tag.

For us, this is occurring on [email protected] and [email protected] and the installation is using multi-site, on the off chance that's important.

[ahockemeyer]

We also are running into this on multiple sites. Ran all the updates and still having this issue. Please prioritize this, our clients need to edit content.

[bengreenbank]

We are experiencing the same issue on multiple sites.

[sparkison]

Have the exact same issues as @corneliusio using Craft 3.7.20 and Redactor 2.7.5 - 2.10.6 and we are not using multisite.

[ChrisDotNet]

We have the same issue.

[smockensturm]

Same here. What's going on @brandonkelly ?

[stefanfriedrich]

same issue for us. clients can't edit the content correctly anymore. @brandonkelly

[timkelty]

Working on a fix, thank you all for your patience.

The regression was introduced here: be78c65

Stay tuned for an update ASAP.

[timkelty]

Could you please test this out and confirm it is working:

"craftcms/redactor": "dev-fix-link-replacement",

[stefanfriedrich]

yeah! works fine for me. (craft 3.6.17) thank you very much!

…

On Tue, Apr 26, 2022 at 5:29 PM Tim Kelty ***@***.***> wrote: Could you please test this out and confirm it is working: "craftcms/redactor": "dev-fix-link-replacement", — Reply to this email directly, view it on GitHub <#384 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMTQGLMNZYXIF7MKQDMNMDVHADW3ANCNFSM5SG2EEJA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[brandonkelly]

@stefanfriedrich Thanks for testing! Just tagged 2.10.7 and 3.0.0-beta.3 with the fix.

[sparkison]

We're still experiencing this issue with Craft 3.7.27.2 and Redactor 2.10.7. Specifically the issues/steps outlined by @corneliusio above:

1. Only seems to occur when linking an entry, asset, or category. Inserting a custom URL does not appear to be causing this.
2. If the text being link proceeds all other links in the field, the link is inserted as expected.
3. If the first item is true and the text being linked follows any other links, the immediately preceding link is overwritten with both the URL and text being defined for the new link, leaving the original text intended to be linked unchanged.

[stefanfriedrich]

works with normal links, but still causes problems with links zu assets.

[timkelty]

@stefanfriedrich @sparkison I can no longer reproduce this with Redactor 2.10.7 (with links to entries or assets):

Here is a video: https://user-images.githubusercontent.com/18329/166471307-93193e01-f38c-4229-9158-80882644919f.mp4

Can you ensure your browser caches are cleared and also clear control panel resource caches?

[sparkison]

Thanks @timkelty, clearing the control panel resources was the trick! 🎉 I can now confirm things are working with both Craft 3.7.27.2 and Craft 3.7.20 with Redactor 2.10.7