Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-label attributes should be used in addition to title #6833

Closed
brandonkelly opened this issue Sep 15, 2020 · 4 comments
Closed

aria-label attributes should be used in addition to title #6833

brandonkelly opened this issue Sep 15, 2020 · 4 comments
Assignees
Labels
accessibility 👤 features related to accessibility bug severity:normal Bugs that affect typical usage

Comments

@brandonkelly
Copy link
Member

Per this Dev.Opera article, aria-label is preferred over title for screen reader support.

There’s a ton of elements in the CP that specify a title but are missing an aria-label attribute.

@brandonkelly brandonkelly added bug severity:normal Bugs that affect typical usage accessibility 👤 features related to accessibility labels Sep 15, 2020
@missmatsuko
Copy link
Contributor

missmatsuko commented Sep 22, 2020

Related: noticed that many of the pages have H1 with an unnecessary title attribute containing the same text. + entries in the entries listing table.

@brandonkelly
Copy link
Member Author

@missmatsuko That is generally intentional, done in places where the text could be truncated, so there’s still a way to see the full value by hovering your cursor over it. Is there a practical downside to doing it?

@missmatsuko
Copy link
Contributor

Is there a reason not to show the whole title in the heading, and have it wrap instead of truncating?

As it is now, the full title wouldn't be available for keyboard users who don't use a screen reader since the full title is only visible on mouse hover.

The title attribute often isn't exposed to screen readers, and in other cases it is read in addition to the original text content.

@brandonkelly
Copy link
Member Author

Is there a reason not to show the whole title in the heading, and have it wrap instead of truncating?

Context: #4548

Happy to consider taking the styles in a different direction though! Maybe @benjamindavid has some ideas…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility 👤 features related to accessibility bug severity:normal Bugs that affect typical usage
Projects
None yet
Development

No branches or pull requests

2 participants