Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long titles mess up the header layout on the edit Entry page #4548

Closed
rungta opened this issue Jul 12, 2019 · 4 comments
Closed

Long titles mess up the header layout on the edit Entry page #4548

rungta opened this issue Jul 12, 2019 · 4 comments
Labels
bug severity:minor Cosmetic issues or bugs with simple workarounds

Comments

@rungta
Copy link

rungta commented Jul 12, 2019

Messed up header on the edit Entry page

Steps to reproduce

  1. Create an entry with 60 or more characters in its title field.

Additional info

  • Craft version: 3.2.1
@brandonkelly brandonkelly added bug severity:minor Cosmetic issues or bugs with simple workarounds labels Jul 13, 2019
brandonkelly added a commit that referenced this issue Jul 31, 2019
@brandonkelly
Copy link
Member

Fixed this for the next release. Here’s a few ways the header will look depending on viewport width:

Edit Entry page header in a wide viewport

Edit Entry page header in a medium-wide viewport

Edit Entry page header on a mobile viewport

Thanks to @sebastian-lenz for the help with title truncation!

@rungta
Copy link
Author

rungta commented Aug 1, 2019

Suggestion: what if we wrap the title instead of truncating it?

Title wrap

@sebastian-lenz
Copy link
Contributor

I prefer the truncated variant. The title should quickly indicate which page the user is on and the full title is always visible in the title field located on all tabs. Also, css cannot truncated multiline text (as far as I am aware) so with multiline display the header could grow in height to unexpected dimensions.

@brandonkelly
Copy link
Member

Also I like having the revision menu connected to the heading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug severity:minor Cosmetic issues or bugs with simple workarounds
Projects
None yet
Development

No branches or pull requests

3 participants