Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile to spreadsheet #410

Closed
wants to merge 2 commits into from
Closed

Profile to spreadsheet #410

wants to merge 2 commits into from

Conversation

bryantaustin13
Copy link
Contributor

Added an operation to create spreadsheet from Profiles.

Given a path to FHIRSpec directories tooling creates a spreadsheet listing the profiles.
Added operation "-ProfilesToSpreadsheet" to create a spreadsheet from profile definitions.json files showing the StructureDefinitions and the element binding valuesets. The spreadsheet is output to:
getOutputPath() (which is passed in as a parameter) + separator + modelName + modelVersion + ".xlsx"
When the tests are run the spreadsheet should be produced: target/test-output/profileToSpreadsheet/QI Core Valueset Analysis10.xlsx.
Addresses ESAC Jira ticket CQF-1175 and CQF-1168.

Also address comments in PR #323 which can be removed when this is approved. This code is for the new tooling application, whereas that PR is for the old and no longer applicable.

  • [X ] I've read the contribution guidelines
  • [ X] Code compiles without errors
  • [ X] Tests are created / updated
  • [ X] Documentation is created / updated

By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0

Copy link
Member

@brynrhodes brynrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get a test failure trying to run this:

[ERROR] Failures:
[ERROR]   ProfilesToSpreadsheetTest.verifySpreadsheetFromProfile:21 ╗ UncheckedIO null\s...
[INFO]
[ERROR] Tests run: 66, Failures: 1, Errors: 0, Skipped: 0
[INFO]

@bryantaustin13
Copy link
Contributor Author

I cannot duplicate this error. I even tried a clean clone to a new directory, switched to this branch, and ran java -jar /Users/bryantaustin/test/cqf-tooling/tooling-cli/target/tooling-cli-2.2.0-SNAPSHOT.jar -ProfilesToSpreadsheet -ip=/Users/bryantaustin/Projects/FHIR-Spec -op=output/test -rp="4.0.1;US-Core/3.1.0;QI-Core/4.1.0" -sp=true -mn=QICore -mv=4.1.0 all from the command line to remove any IntelliJ contamination. And it produced the spreadsheet I would have expected.
That error points to line 21 where the profileToSpreadsheet operation is called. Within the operation, I THINK, the only file i/o occurs in ProfilesToSpreadsheet.writeSpreadSheet() and that has a try catch around all file io.

@brynrhodes
Copy link
Member

Closing this as superseded by #416

@brynrhodes brynrhodes closed this Jan 31, 2023
@JPercival JPercival deleted the profileToSpreadsheet branch November 28, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants