Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/force upload local method #1165

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Fix/force upload local method #1165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39c385e
fix: Correct startOpenPathUploadAndPipeline types
zatteo Feb 13, 2024
01f81d7
fix: Call OpenPath pipeline when using force upload intent
zatteo Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/domain/geolocation/services/tracking.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
startTracking,
stopTracking,
sendLogFile,
uploadData,
startOpenPathUploadAndPipeline,
getId,
updateId,
stopTrackingAndClearData,
Expand Down Expand Up @@ -46,7 +46,7 @@ export const sendGeolocationTrackingLogs = async (
}

export const forceUploadGeolocationTrackingData = async (): Promise<void> => {
await uploadData({ force: true })
await startOpenPathUploadAndPipeline({ force: true })
}

interface GeolocationTrackingStatus {
Expand Down
4 changes: 2 additions & 2 deletions src/app/domain/geolocation/tracking/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,8 @@ export const handleConnectivityChange = async event => {
* as soon as the trips are ready to be fetched.
*
* @typedef {object} Params
* @property {number} untilTS - Until when the locations points should be fetched. Default is 0
* @property {boolean} force - Whether or not the upload should be forced
* @property {number} [untilTs] - Until when the locations points should be fetched. Default is 0
* @property {boolean} [force] - Whether or not the upload should be forced
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know this syntax, is it because those params are optionals?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

*
* @param {Params} - The method parmas
*/
Expand Down
Loading