Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/force upload local method #1165

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Fix/force upload local method #1165

merged 2 commits into from
Feb 14, 2024

Conversation

zatteo
Copy link
Contributor

@zatteo zatteo commented Feb 13, 2024

### 🔧 Tech

* "Force data upload" debug button triggers pipeline so trips will appear directly on coachco2

Checklist

Before merging this PR, the following things must have been done if relevant:

  • Tested on iOS
  • Tested on Android
  • Test coverage
  • README and documentation

A debug button on coachco2 calls a force upload intent on flagship
side. But we forgot to update the force upload call to use the new
method that runs the OpenPath pipeline after a force upload.
Copy link
Contributor

@paultranvan paultranvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

* @property {number} untilTS - Until when the locations points should be fetched. Default is 0
* @property {boolean} force - Whether or not the upload should be forced
* @property {number} [untilTs] - Until when the locations points should be fetched. Default is 0
* @property {boolean} [force] - Whether or not the upload should be forced
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know this syntax, is it because those params are optionals?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@zatteo zatteo merged commit bd220e4 into master Feb 14, 2024
1 check passed
@zatteo zatteo deleted the fix/force-upload-local-method branch February 14, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants