Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate UniswapV3 pool fetching periodic maintenance #427

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

sunce86
Copy link
Contributor

@sunce86 sunce86 commented Aug 8, 2022

This PR activates periodic background maintenance task to update the pools liquidity on UniswapV3 pools (I forgot to add this in #388).

Initially, this was intended to be done with:
uniswap_v3_pool_fetcher.spawn_maintenance_task(...)
but it makes more sense to me to add this function to the ServiceMaintenance which is triggered on each new block. Although currently UniswapV3 is using subgraph under the hood, this change makes even more sense since we are moving towards an event based pool liquidity update.

@sunce86 sunce86 requested a review from a team as a code owner August 8, 2022 14:35
Copy link
Contributor

@nlordell nlordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #427 (4ca1b20) into main (1e5aa9e) will increase coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 4ca1b20 differs from pull request most recent head f118b82. Consider uploading reports for the commit f118b82 to get more accurate results

@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   64.32%   64.37%   +0.04%     
==========================================
  Files         227      227              
  Lines       43450    43425      -25     
==========================================
+ Hits        27950    27953       +3     
+ Misses      15500    15472      -28     

@sunce86 sunce86 enabled auto-merge (squash) August 8, 2022 14:45
@sunce86 sunce86 merged commit c062703 into main Aug 8, 2022
@sunce86 sunce86 deleted the event-based-pool-fetching branch August 8, 2022 14:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants