-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UniswapV3 liquidity to driver #388
Conversation
Codecov Report
@@ Coverage Diff @@
## main #388 +/- ##
==========================================
- Coverage 64.19% 63.89% -0.31%
==========================================
Files 223 227 +4
Lines 42221 43184 +963
==========================================
+ Hits 27105 27593 +488
- Misses 15116 15591 +475 |
@@ -4,9 +4,11 @@ use anyhow::{bail, Result}; | |||
use lazy_static::lazy_static; | |||
use reqwest::{Client, IntoUrl, Url}; | |||
use serde::{de::DeserializeOwned, Deserialize, Serialize}; | |||
use serde_json::{Map, Value}; | |||
use serde_json::{json, Map, Value}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes from this file are already reviewed here: cowprotocol/cow-native-liquidity@d2c1a6c
@@ -0,0 +1,449 @@ | |||
//! Module containing The Graph API client used for retrieving Uniswap V3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes from this file are already reviewed here: https://github.com/cowprotocol/cow-native-liquidity/blob/master/liquidity-sources/src/sources/uniswap_v3/graph_api.rs
@@ -0,0 +1,390 @@ | |||
use super::graph_api::{PoolData, Token, UniV3SubgraphClient}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes from this file are already reviewed here: https://github.com/cowprotocol/cow-native-liquidity/blob/master/liquidity-sources/src/sources/uniswap_v3/pool_fetching.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. My only comment is I think we should be able to send UniV3 liquidity to Quasimodo for price estimates as well.
This PR integrates UniswapV3 liquidity pool fetcher with the driver and sends the native liquidity to solvers.
I've marked the code that is already reviewed and copy-pasted from https://github.com/cowprotocol/cow-native-liquidity.