Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] refactor(tokens): wire up components to new hooks #3198

Merged
merged 6 commits into from
Oct 26, 2023

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Oct 10, 2023

Summary

In this PR I mostly replaced legacy hooks and state to a new @cowprotocol/tokens. The goal is to bind App logic to a new source of data.

I also continued working on migrating from Uniswap entities.

To Test

Please, test everything in #3201

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
swap-dev 🔄 Building (Inspect) Visit Preview Oct 26, 2023 0:38am

🌃 Cosmos ↗︎

@@ -0,0 +1,64 @@
import { useMemo } from 'react'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just moved this file from another directory, changed nothing here

@shoom3301 shoom3301 changed the title Refactor/tokens lib wiring 3 [4.3] refactor(tokens): wire up components to new hooks Oct 10, 2023
@shoom3301 shoom3301 self-assigned this Oct 10, 2023
@shoom3301 shoom3301 requested a review from a team October 11, 2023 12:27
@shoom3301 shoom3301 marked this pull request as ready for review October 11, 2023 12:27
@@ -50,7 +50,6 @@ const PageView = {
}

export default function TokensOverview() {
useInitFavouriteTokens()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

…protocol/cowswap into refactor/tokens-lib-wiring-3

# Conflicts:
#	apps/cowswap-frontend/src/legacy/components/Header/index.tsx
* refactor(tokens): use new tokens UI and logic by default (#3200)

* fix(tokens): fix e2e tests for tokens updates (#3193)

* refactor(tokens): remove legacy code (#3194)

* fix(tokens): fix tokens list loading state (#3201)
@shoom3301 shoom3301 merged commit 2a6cafc into refactor/tokens-lib-wiring-2 Oct 26, 2023
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
@alfetopito alfetopito deleted the refactor/tokens-lib-wiring-3 branch October 26, 2023 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants