Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.5] refactor(tokens): use new tokens UI and logic by default #3200

Merged
merged 5 commits into from
Oct 26, 2023
Merged

[4.5] refactor(tokens): use new tokens UI and logic by default #3200

merged 5 commits into from
Oct 26, 2023

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Oct 10, 2023 •
edited
Loading

Summary

image

In this PR I eventually injected the new tokens UI into App.

  1. Removed using legacy CurrencySearchModal
  2. Added TokensListsUpdater
  3. Added AutoImportTokens
  4. Bind useOpenTokenSelectWidget()

To Test

Please, test everything in #3201

@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited by github-actions bot
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
swap-dev 🔄 Building (Inspect) Visit Preview Oct 26, 2023 0:37am

🌃 Cosmos ↗︎

@shoom3301 shoom3301 changed the title Refactor/tokens lib wiring 5 [4.5] refactor(tokens): use new tokens UI and logic by default Oct 10, 2023
@shoom3301 shoom3301 self-assigned this Oct 10, 2023
@shoom3301 shoom3301 requested a review from a team October 11, 2023 12:33
@shoom3301 shoom3301 marked this pull request as ready for review October 11, 2023 12:33
anxolin
anxolin approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but when all is consolidated we will need a last check as this PR don't compile

@shoom3301
fix(tokens): fix e2e tests for tokens updates (#3193)
ad2fe93 
* refactor(tokens): remove legacy code (#3194)

* fix(tokens): fix tokens list loading state (#3201)
@shoom3301 shoom3301 merged commit f010437 into refactor/tokens-lib-wiring-4 Oct 26, 2023
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
@alfetopito alfetopito deleted the refactor/tokens-lib-wiring-5 branch October 26, 2023 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

@alfetopito alfetopito alfetopito approved these changes

Assignees

@shoom3301 shoom3301

Labels
Tokens
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoom3301 @alfetopito @anxolin