-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic linkage for CocoaPods #750
Conversation
Use the latest 1.1.10802 which has arm64e removed, uses proper framework install names, and dynamic linkage for CocoaPods.
Now that CLOpenSSL is using dynamic linkage, we can switch Themis back to using dynamic linkage too (as it was before). The "themis" pod will have to continue being a dynamic framework Pod to avoid breaking existing builds.
arm64e slice in binary dynamic frameworks causes issues with CocoaPods so it has been removed from CLOpenSSL starting with 1.1.10802. However, Carthage builds use Xcode project which still requires arm64e. Remove arm64e from the architectures list as it is not available now.
The builds is currently broken, should fixed once #751 is merged (and the build restarted). |
Co-authored-by: vixentael <[email protected]> Co-authored-by: vixentael <[email protected]>
I don't really like to pin OpenSSL versions, but @vixentael is being extra paranoid, and I'm honestly tired of this madness, so whatever floats your boat. |
yeah, sorry, i'm tired of being pushed to update our own libraries urgently because they suddenly introduce breaking changes. |
As it turns out, code examples are broken with Themis 0.13.5 once CLOpenSSL 1.1.10802 has been released. Given that CI is broken, we're currently ignoring it (again, and again). |
As it turned out in #752, the proper way to pin Carthage binary dependency is to use
which will then result in the following
One cannot use
|
Update to latest CLOpenSSL 1.1.10802 which uses dynamic linkage (and removes some architecture slices for that).
Now that CLOpenSSL is using dynamic linkage, we can switch Themis back to using dynamic linkage too (as it was before). The
themis
pod will have to continue being a dynamic framework Pod to avoid breaking existing builds.arm64e
slice in binary dynamic frameworks causes issues with CocoaPods so it has been removed from CLOpenSSL starting with 1.1.10802. However, Carthage builds use Xcode project which still requiresarm64e
. Removearm64e
from the architectures list as it is not available now.Checklist