Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api)!: relocate *_update_time and *_update_height and add missing stores for client upgrade #915

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Oct 11, 2023

Closes: #913
Closes: #914

Integration tests: informalsystems/basecoin-rs#136


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (fd472b8) 67.54% compared to head (feff3a0) 67.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   67.54%   67.53%   -0.01%     
==========================================
  Files         131      131              
  Lines       16105    16111       +6     
==========================================
+ Hits        10878    10881       +3     
- Misses       5227     5230       +3     
Files Coverage Δ
crates/ibc/src/core/context.rs 50.00% <ø> (ø)
crates/ibc/src/core/ics02_client/client_state.rs 50.00% <ø> (ø)
crates/ibc/src/core/ics02_client/error.rs 24.32% <ø> (ø)
...ibc/src/core/ics02_client/handler/create_client.rs 83.58% <100.00%> (-0.93%) ⬇️
...ibc/src/core/ics02_client/handler/update_client.rs 95.23% <ø> (-0.22%) ⬇️
crates/ibc/src/core/ics03_connection/delay.rs 75.60% <100.00%> (+2.63%) ⬆️
crates/ibc/src/core/ics04_channel/context.rs 98.18% <100.00%> (ø)
crates/ibc/src/core/ics04_channel/error.rs 26.08% <ø> (ø)
.../src/core/ics04_channel/handler/acknowledgement.rs 89.20% <ø> (ø)
.../ibc/src/core/ics04_channel/handler/recv_packet.rs 88.78% <ø> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani merged commit 513901f into main Oct 12, 2023
@Farhad-Shabani Farhad-Shabani deleted the farhad/replace-client-update-time-height branch October 12, 2023 01:23
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
…sing stores for client upgrade (#915)

* imp: replace update_client_time/height under ClientValidationContext

* misc: add unclog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants