Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing to update host’s hight and timestamp upon a successful upgrade client #913

Closed
Farhad-Shabani opened this issue Oct 11, 2023 · 0 comments · Fixed by #915
Closed
Assignees
Labels
A: bug Admin: something isn't working
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Summary

When performing a client upgrade, the pertinent incoming message undergoes processing within the update_state_on_upgrade method. In this process, the handler only updates the store with the new client and consensus states. However, it is essential to note that the associated metadata, which records the timestamp and height of hosts where the upgrade was processed, also requires updating.

To ensure this, it is imperative to call both the store_update_time and store_update_height methods just after storing the upgraded client and consensus states.

@Farhad-Shabani Farhad-Shabani added the A: bug Admin: something isn't working label Oct 11, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Oct 11, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Oct 11, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Oct 12, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.46.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
Status: Done
1 participant