Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some naming in the Transfer app to align with our convention #514

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

Farhad-Shabani
Copy link
Member

Closes: #506


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review March 9, 2023 15:52
@Farhad-Shabani Farhad-Shabani requested a review from plafer March 9, 2023 15:53
@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 72.69% and project coverage change: +0.03 🎉

Comparison is base (a7f8062) 71.80% compared to head (0237570) 71.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #514      +/-   ##
==========================================
+ Coverage   71.80%   71.83%   +0.03%     
==========================================
  Files         126      126              
  Lines       15820    15852      +32     
==========================================
+ Hits        11359    11387      +28     
- Misses       4461     4465       +4     
Impacted Files Coverage Δ
crates/ibc/src/applications/transfer/context.rs 51.06% <0.00%> (ø)
crates/ibc/src/applications/transfer/relay.rs 0.00% <0.00%> (ø)
.../src/applications/transfer/relay/on_recv_packet.rs 0.00% <0.00%> (ø)
crates/ibc/src/core/ics04_channel/packet.rs 47.30% <40.00%> (ø)
...tes/ibc/src/applications/transfer/msgs/transfer.rs 46.53% <63.63%> (ø)
.../src/core/ics04_channel/handler/acknowledgement.rs 85.51% <70.00%> (+0.27%) ⬆️
.../ibc/src/core/ics04_channel/handler/send_packet.rs 82.17% <71.42%> (+0.54%) ⬆️
...src/core/ics04_channel/handler/timeout_on_close.rs 86.16% <73.07%> (+0.27%) ⬆️
crates/ibc/src/core/context.rs 84.09% <75.00%> (ø)
...ates/ibc/src/core/ics04_channel/handler/timeout.rs 89.30% <82.75%> (+0.03%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@plafer plafer merged commit 7311bbd into main Mar 9, 2023
@plafer plafer deleted the farhad/adjust-naming branch March 9, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: breaking Admin: breaking change that may impact operators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Transfer App] Make naming consistent with our convention
2 participants