Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transfer App] Make naming consistent with our convention #506

Closed
Farhad-Shabani opened this issue Mar 8, 2023 · 0 comments · Fixed by #514
Closed

[Transfer App] Make naming consistent with our convention #506

Farhad-Shabani opened this issue Mar 8, 2023 · 0 comments · Fixed by #514
Assignees
Labels
A: breaking Admin: breaking change that may impact operators O: code-hygiene Objective: aims to improve code hygiene
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Mar 8, 2023

Problem Statement

  • Some of the field names in MsgTransfer do not follow our naming convention (e.g. port_on_a instead of port_id_on_a)
  • Also, Inconsistent naming is being used for variables and methods that deal with AccountId. We are using address and account interchangeably like here
@Farhad-Shabani Farhad-Shabani added O: code-hygiene Objective: aims to improve code hygiene A: breaking Admin: breaking change that may impact operators labels Mar 8, 2023
@github-project-automation github-project-automation bot moved this to ✅ Done in ibc-rs Mar 9, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.32.0 milestone Mar 9, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: breaking Admin: breaking change that may impact operators O: code-hygiene Objective: aims to improve code hygiene
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant