Investigate: streamline Protobuf abstraction or re-export from tendermint-proto
#116
Comments
ljoss17
added a commit
that referenced
this issue
Oct 19, 2023
ibc-proto-rs v0.38.0 October 19th, 2023 This release contains a breaking change, where the `Protobuf` trait is not object-safe any longer, but rather re-exported from the `tendermint-proto` crate. It also updates the Interchain Security protos to include misbehaviour-related messages. BREAKING CHANGES: - Switch from using object safe `Protobuf` definitions and re-export `Protobuf` from `tendermint-proto` crate` instead. (#116) FEATURES: - Update CCV provider protos to include misbehaviour-related messages (#113)
Farhad-Shabani
added a commit
that referenced
this issue
Nov 28, 2023
ibc-proto-rs v0.38.0 October 19th, 2023 This release contains a breaking change, where the `Protobuf` trait is not object-safe any longer, but rather re-exported from the `tendermint-proto` crate. It also updates the Interchain Security protos to include misbehaviour-related messages. BREAKING CHANGES: - Switch from using object safe `Protobuf` definitions and re-export `Protobuf` from `tendermint-proto` crate` instead. (#116) FEATURES: - Update CCV provider protos to include misbehaviour-related messages (#113)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
With the changes made in
ibc-rsvia ADR07 (see the relevant discussion), we no longer dispatch dynamic types, which means theProtobuftrait doesn't need to be object safe. That being said, if it wouldn’t be needed for any other places or projects, we might be able to simplifyProtobufabstraction inibc-proto-rsor even can simply re-export it from thetendermint_protocrate.Ofc, after getting
Protobuftrait intendermint-protosynced with the latest changes inibc-proto-rs(this issue)The text was updated successfully, but these errors were encountered: