Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove error variant of encode{,_length_delimited}_vec methods in Protobuf trait #1323

Closed
Farhad-Shabani opened this issue Jul 11, 2023 · 0 comments · Fixed by #1324
Closed

Remove error variant of encode{,_length_delimited}_vec methods in Protobuf trait #1323

Farhad-Shabani opened this issue Jul 11, 2023 · 0 comments · Fixed by #1324
Labels
enhancement New feature or request

Comments

@Farhad-Shabani
Copy link
Member

Description

In accordance with the underlying prost::Message interface, encode_vec and encode_length_delimited_vec methods of the Protobuf trait can explicitly return Vec<u8>, without requiring error handling.

Definition of "done"

Similar to what was done with the Protobuf trait in ibc-proto-rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@Farhad-Shabani