Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Create a new test suite ForwardingTestSuite #6785

Merged
merged 5 commits into from
Jul 9, 2024
Merged

chore: Create a new test suite ForwardingTestSuite #6785

merged 5 commits into from
Jul 9, 2024

Conversation

NisTun
Copy link
Contributor

@NisTun NisTun commented Jul 8, 2024

Description

closes: #6715

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

DimitrisJim
DimitrisJim approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Pushed a small fix to trigger these, see comment, thanks for picking it up!

modules/apps/transfer/keeper/relay_forwarding_test.go
amountType int
)

func TestForwardingTestSuite(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future reference since this also tripped me up in past, this function is needed else the tests will not even actually run! 😄

chatton
chatton approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one sylistic nit around the struct declaration but otherwise looks great! Thanks for picking this up

modules/apps/transfer/keeper/relay_forwarding_test.go Outdated Show resolved Hide resolved
@DimitrisJim DimitrisJim added this pull request to the merge queue Jul 9, 2024
Merged via the queue into cosmos:main with commit 6bf82f2 Jul 9, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@chatton chatton chatton approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a new test suite ForwardingTestSuite
3 participants
@NisTun @chatton @DimitrisJim