Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a new test suite ForwardingTestSuite #6715

Closed
bznein opened this issue Jun 27, 2024 · 2 comments · Fixed by #6785
Closed

Create a new test suite ForwardingTestSuite #6715

bznein opened this issue Jun 27, 2024 · 2 comments · Fixed by #6785
Assignees
@NisTun
Labels
good first issue Good for newcomers testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@bznein
Copy link
Contributor

bznein commented Jun 27, 2024 •
edited by DimitrisJim
Loading

Some food for thought for a future refactor or cleanup.. Maybe we should consider a ForwardingTestSuite for forwarding tests, since spinning up 4 in process apps is wasteful for most other transfer tests.

Originally posted by @damiannolan in #6713 (comment)
@bznein bznein changed the title Create a new test suite Forwarding Test Suite Create a new test suite ForwardingTestSuite Jun 27, 2024
@DimitrisJim DimitrisJim added testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces labels Jun 27, 2024
@crodriguezvega crodriguezvega added the good first issue Good for newcomers label Jun 27, 2024
@NisTun
Copy link
Contributor

NisTun commented Jul 8, 2024

Can I handle this issue @bznein

@DimitrisJim
Copy link
Contributor

go for it @NisTun! thanks!

@NisTun NisTun mentioned this issue Jul 8, 2024
Merged
10 tasks
@DimitrisJim DimitrisJim moved this to In review 👀 in ibc-go Jul 9, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🥳 in ibc-go Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NisTun NisTun

Labels
good first issue Good for newcomers testing Testing package and unit/integration tests type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Status: Done 🥳
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Create a new test suite ForwardingTestSuite NisTun/ibc-go
4 participants
@crodriguezvega @DimitrisJim @bznein @NisTun