refactor(core)!: move telemetry into internal folder #6763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan and
chatton
as code owners
crodriguezvega
approved these changes
Jul 4, 2024
| ibcmetrics "github.com/cosmos/ibc-go/v8/modules/core/metrics" | ||
| ) | ||
|
|
||
| func ReportCreateClient(clientType string) { |
There was a problem hiding this comment.
Should we add doc strings to all these public functions?
There was a problem hiding this comment.
That might be nice. In case someone is wondering if they should use them or not, a bit of explanation on how and when they are supposed to be used.
Potentially a small text or readme even on how we use telemetry?
There was a problem hiding this comment.
mentioned in other PR that completely indifferent to docu strings considering they are internal use only. A small description on telemetry usage would be nice though I am still not entirely sure who consumes these atm.
gjermundgaraba
approved these changes
Jul 8, 2024
damiannolan
reviewed
Jul 8, 2024
…separate folder for core/02-client.
DimitrisJim
force-pushed
the
jim/internal-telemetry-core
branch
from
10681b9 to
72d4205
Compare
damiannolan
approved these changes
Jul 9, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additionally, move the
metric.gofiles fromtypes/into ametricspackage to handle import cycles. This can contain all labels for the core module.closes: #6425
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.