Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move telemetry functionality for core in a separate file #6425

Closed
3 tasks
DimitrisJim opened this issue May 29, 2024 · 2 comments · Fixed by #6763
Closed
3 tasks

Move telemetry functionality for core in a separate file #6425

DimitrisJim opened this issue May 29, 2024 · 2 comments · Fixed by #6763
Labels
nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented May 29, 2024

Telemetry information grabs a good amount of space inside a function and can make it harder to parse, it would be nice if the functionality for it can be moved in a separate telemetry.go file so as to not get in the way of more important code.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@DimitrisJim DimitrisJim added nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces icebox Issues that we will not address for the time being labels May 29, 2024
@DimitrisJim
Copy link
Contributor Author

Can open issues for other places this can be done. Told @gjermundgaraba to open up the first PR on this to get other contributors with a template to work with.

@DimitrisJim DimitrisJim removed the icebox Issues that we will not address for the time being label Jun 5, 2024
@DimitrisJim DimitrisJim changed the title Move telemetry functionality in a separate file Move telemetry functionality for core in a separate file Jun 7, 2024
@DimitrisJim
Copy link
Contributor Author

Seems only other place that is relevant for this might be core/, capability just has one call to it in its BeginBlock that doesn't warrant moving.

The relevant calls that could do with moving involve the IncrCounterWithLabels, those are the ones which involve more real estate that gets in the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant