Cancel in progress workflows on new commit #6759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
reviewed
Jul 3, 2024
| @@ -16,6 +16,9 @@ on: | |||
| - synchronize | |||
| # trigger workflow if PR is marked ready for review. | |||
| - ready_for_review | |||
| concurrency: | |||
| group: ${{ github.ref }} | |||
There was a problem hiding this comment.
do we want to group by workflow just in case? https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-concurrency-and-the-default-behavior
I don't think this would have any tangible diff, though.
There was a problem hiding this comment.
I think we don't need to right? I think it's fair to say that if we push a new commit we want to cancel everything that was running and just re-run them from scratch with the new code
DimitrisJim
reviewed
Jul 4, 2024
| @@ -16,6 +16,9 @@ on: | |||
| - synchronize | |||
| # trigger workflow if PR is marked ready for review. | |||
| - ready_for_review | |||
| concurrency: | |||
| group: ${{ github.ref }} | |||
| cancel-in-progress: ${{ github.ref != 'refs/heads/main' }} | |||
There was a problem hiding this comment.
cancels if not on main, right?
There was a problem hiding this comment.
yep this is my understanding of it, we will leave the ones that run on main alone
DimitrisJim
approved these changes
Jul 4, 2024
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
damiannolan,
gjermundgaraba and
bznein
as code owners
bznein
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can start with this on just the regular e2es and wasm e2es which should be the ones that will have the most redundant runs.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.