-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a method to check if the scope module already exists in the capability keeper (backport #6716) #6732
feat: add a method to check if the scope module already exists in the capability keeper (backport #6716) #6732
Conversation
… capability keeper (#6716) * add method to check if the scope module already exist * chore: add changelog * Update modules/capability/keeper/keeper_test.go Co-authored-by: Nikolas De Giorgis <[email protected]> --------- Co-authored-by: DimitrisJim <[email protected]> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Nikolas De Giorgis <[email protected]> (cherry picked from commit 8942179) # Conflicts: # modules/capability/CHANGELOG.md
Cherry-pick of 8942179 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending conflict resolution (which I can do if no soul picks it up in next 10-15')
modules/capability/CHANGELOG.md
Outdated
* [\#4068](https://github.com/cosmos/ibc-go/pull/4068) Upgrade capability module to cosmos-sdk v0.51.0 | ||
======= | ||
* [\#6193](https://github.com/cosmos/ibc-go/pull/6193) Bump Cosmos SDK to v0.50.6. | ||
* [\#6193](https://github.com/cosmos/ibc-go/pull/6193) Bump `cosmossdk.io/store` to v1.1.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this changelog can be removed. And we can open a PR to the release branch to bump cosmos-sdk and cometbft deps to align with latest ibc-go releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rm'ing em
Feel free to pick up if you want! Otherwise I can do it in a little bit :) |
Description
Add method
HasModule(moduleName string)
to check if the scope module already exists in the capability keeper. This method can help avoid creating two scope keepers by mistake and panicking the chain, and it helps the workaround to make IBC work with the app wiring chains.This is an automatic backport of pull request #6716 done by [Mergify](https://mergify.com).