feat: add a method to check if the scope module already exists in the capability keeper #6716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pantani
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
damiannolan,
chatton,
DimitrisJim,
gjermundgaraba and
bznein
as code owners
DimitrisJim
approved these changes
Jun 28, 2024
Do you have a use case for not sealing the capability keeper and using Either way, happy to merge this addition. We should be able to make a patch release of x/capability to include it! |
bznein
approved these changes
Jul 1, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jul 1, 2024
… capability keeper (#6716) * add method to check if the scope module already exist * chore: add changelog * Update modules/capability/keeper/keeper_test.go Co-authored-by: Nikolas De Giorgis <[email protected]> --------- Co-authored-by: DimitrisJim <[email protected]> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Nikolas De Giorgis <[email protected]> (cherry picked from commit 8942179) # Conflicts: # modules/capability/CHANGELOG.md
damiannolan
added a commit
that referenced
this pull request
Jul 1, 2024
… capability keeper (backport #6716) (#6732) * feat: add a method to check if the scope module already exists in the capability keeper (#6716) * add method to check if the scope module already exist * chore: add changelog * Update modules/capability/keeper/keeper_test.go Co-authored-by: Nikolas De Giorgis <[email protected]> --------- Co-authored-by: DimitrisJim <[email protected]> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Nikolas De Giorgis <[email protected]> (cherry picked from commit 8942179) # Conflicts: # modules/capability/CHANGELOG.md * chore: fix conflicts * chore: update changelog --------- Co-authored-by: Danilo Pantani <[email protected]> Co-authored-by: DimitrisJim <[email protected]> Co-authored-by: Damian Nolan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add method
HasModule(moduleName string)to check if the scope module already exists in the capability keeper. This method can help avoid creating two scope keepers by mistake and panicking the chain, and it helps the workaround to make IBC work with the app wiring chains.