fix(callbacks)!: SendPacket validation bypass and erroneous event emission are fixed (backport #4568) #5173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gic (cosmos#4375) * imp(callbacks/mock/contract_keeeper): improved contract keeper logic * imp(callbacks_test): fixed transfer_test.go * imp(callbacks_test): fixed ica_test.go * imp(callbacks_test): fixed fee_transfer_test.go * style(callbacks_test): removed unneeded gas_limit * style: ran golangci-lint * imp(callbacks_test): implemented simplified logic * imp(callbacks_test): removed unneeded variable * imp(callbacks): implemented some review feedback * docs(callbacks/simapp): updated godocs of mock contract keeper functions
…ssion are fixed (cosmos#4568) * fix: fixed callbacks out of gas handling * fix: fixed panics and oog errors not showing up on events * docs(callbacks): added godocs for error precedence --------- Co-authored-by: Carlos Rodriguez <[email protected]>
mmsqe
requested review from
colin-axner,
AdityaSripal,
damiannolan and
srdtrk
as code owners
|
Thanks for the PR, @mmsqe. However, we will backport these two PRs using mergify (it's just easier for us to keep track of what PRs get back ported). Then I will close this one and #5882 and #5881 should get the changes in the release branch. Do you specifically have an urgent need to get these changes in a release? |
|
@crodriguezvega Got it thanks, it's not an issue for us now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #4568 to v0.2.x+ibc-go-v7.3.x with related #4375 test change.
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.