fix(callbacks)!: SendPacket validation bypass and erroneous event emission are fixed #4568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srdtrk
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
chatton
reviewed
Sep 5, 2023
colin-axner
reviewed
Sep 5, 2023
| if callbackData.AllowRetry() { | ||
| panic(storetypes.ErrorOutOfGas{Descriptor: fmt.Sprintf("ibc %s callback out of gas; commitGasLimit: %d", callbackType, callbackData.CommitGasLimit)}) | ||
| } | ||
| err = errorsmod.Wrapf(types.ErrCallbackOutOfGas, "ibc %s callback out of gas", callbackType) |
There was a problem hiding this comment.
I guess we are okay overwriting the returned error if the cached context runs of gas?
There was a problem hiding this comment.
I guess we have an order of precedence now:
regularErr < panicErr < pastLimitErr
There was a problem hiding this comment.
I'm okay with that since the panics are likely due to out of gas error anyways
There was a problem hiding this comment.
Could we update godoc with this order of precedence and behaviour?
colin-axner
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Changes LGTM, a little more documentation could be useful. Thank you @srdtrk for the attention to detail! This is a state machine breaking change so will require a v0.2.0 when we backport
| if callbackData.AllowRetry() { | ||
| panic(storetypes.ErrorOutOfGas{Descriptor: fmt.Sprintf("ibc %s callback out of gas; commitGasLimit: %d", callbackType, callbackData.CommitGasLimit)}) | ||
| } | ||
| err = errorsmod.Wrapf(types.ErrCallbackOutOfGas, "ibc %s callback out of gas", callbackType) |
There was a problem hiding this comment.
Could we update godoc with this order of precedence and behaviour?
crodriguezvega
approved these changes
Sep 7, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
…ssion are fixed (#4568) * fix: fixed callbacks out of gas handling * fix: fixed panics and oog errors not showing up on events * docs(callbacks): added godocs for error precedence --------- Co-authored-by: Carlos Rodriguez <[email protected]> (cherry picked from commit e192899) # Conflicts: # modules/apps/callbacks/ibc_middleware.go
3 tasks
mmsqe
pushed a commit
to mmsqe/ibc-go
that referenced
this pull request
Nov 27, 2023
…ssion are fixed (cosmos#4568) * fix: fixed callbacks out of gas handling * fix: fixed panics and oog errors not showing up on events * docs(callbacks): added godocs for error precedence --------- Co-authored-by: Carlos Rodriguez <[email protected]>
9 tasks
mergify bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
…ssion are fixed (#4568) * fix: fixed callbacks out of gas handling * fix: fixed panics and oog errors not showing up on events * docs(callbacks): added godocs for error precedence --------- Co-authored-by: Carlos Rodriguez <[email protected]> (cherry picked from commit e192899) # Conflicts: # modules/apps/callbacks/ibc_middleware.go
9 tasks
srdtrk
added a commit
that referenced
this pull request
Mar 22, 2024
…ssion are fixed (backport #4568) (#5881) * fix(callbacks)!: SendPacket validation bypass and erroneous event emission are fixed (#4568) * fix: fixed callbacks out of gas handling * fix: fixed panics and oog errors not showing up on events * docs(callbacks): added godocs for error precedence --------- Co-authored-by: Carlos Rodriguez <[email protected]> (cherry picked from commit e192899) # Conflicts: # modules/apps/callbacks/ibc_middleware.go * fix conflicts * fix import --------- Co-authored-by: srdtrk <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #4566, #4567
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.