Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add HasValidateBasic compiler assertions to msgs #4684

Closed
wants to merge 1 commit into from

Conversation

trinitys7
Copy link
Contributor

Description

Add the HasValidateBasic interface as a compiler assertion to each of the ibc-go tx msgs.

closes: #4665

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, go fmt is needed

@colin-axner
Copy link
Contributor

colin-axner commented Sep 18, 2023

Hi @trinitys7, thanks for the contribution! Looks like the linter needs to be fixed and the branch will need to be kept up to date with main before merge. We will be happy to do this for you if you could allow us to push to your branch (usually there's something you can click on the right hand side of this pr)

@trinitys7
Copy link
Contributor Author

@colin-axner, I made this PR from my organization fork, which doesn't allow maintainers to make edits. I will close this PR and create another one from my personal fork instead.

@trinitys7 trinitys7 closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HasValidateBasic compiler assertions to msgs
6 participants