Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HasValidateBasic compiler assertions to msgs #4665

Closed
7 tasks
damiannolan opened this issue Sep 15, 2023 · 0 comments · Fixed by #4724
Closed
7 tasks

Add HasValidateBasic compiler assertions to msgs #4665

damiannolan opened this issue Sep 15, 2023 · 0 comments · Fixed by #4724
Labels
good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
v8.0.0

Comments

@damiannolan
Copy link
Member

Summary

Add the HasValidateBasic interface as a compiler assertion to each of the ibc-go tx msgs.

The msgs are generally maintained under package types of each module.

  • core
  • transfer
  • interchain-accounts
  • fee

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces v8 labels Sep 15, 2023
@damiannolan damiannolan added this to the v8.0.0 milestone Sep 15, 2023
@damiannolan damiannolan moved this to Todo in ibc-go Sep 15, 2023
@trinitys7 trinitys7 mentioned this issue Sep 17, 2023
Closed
9 tasks
@crodriguezvega crodriguezvega moved this from Todo to In review in ibc-go Sep 18, 2023
@trinitys7 trinitys7 mentioned this issue Sep 19, 2023
Merged
9 tasks
@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type: code hygiene Clean up code but without changing functionality or interfaces
Projects
ibc-go
Archived in project
Milestone
v8.0.0
1 participant
@damiannolan