Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logging in total escrow migration #3766

Merged
merged 3 commits into from
Jun 7, 2023
Merged

add logging in total escrow migration #3766

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acd2d27
add logging in total escrow migration
Jun 6, 2023
e9be711
Merge branch 'main' into carlos/add-logging-total-escrow-migration
Jun 7, 2023
230c12b
Merge branch 'main' into carlos/add-logging-total-escrow-migration
Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/apps/transfer/keeper/migrations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ func (m Migrator) MigrateTotalEscrowForDenom(ctx sdk.Context) error {
m.keeper.SetTotalEscrowForDenom(ctx, totalEscrow)
}

logger := m.keeper.Logger(ctx)
logger.Info("successfully set total escrow for %d denominations", totalEscrowed.Len())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we also want to log the totalEscrow amount?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that would add much value to the reader? I just wanted to have a simple message, since Stride run the migration and noticed that there was no indication in the logs of whether the migration succeeded or not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, that makes sense!

return nil
}

Expand Down