add logging in total escrow migration #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
damiannolan
approved these changes
Jun 7, 2023
DimitrisJim
approved these changes
Jun 7, 2023
charleenfei
reviewed
Jun 7, 2023
| @@ -81,6 +81,8 @@ func (m Migrator) MigrateTotalEscrowForDenom(ctx sdk.Context) error { | |||
| m.keeper.SetTotalEscrowForDenom(ctx, totalEscrow) | |||
| } | |||
|
|
|||
| logger := m.keeper.Logger(ctx) | |||
| logger.Info("successfully set total escrow for %d denominations", totalEscrowed.Len()) | |||
There was a problem hiding this comment.
do we also want to log the totalEscrow amount?
There was a problem hiding this comment.
Not sure if that would add much value to the reader? I just wanted to have a simple message, since Stride run the migration and noticed that there was no indication in the logs of whether the migration succeeded or not.
There was a problem hiding this comment.
Ah ok, that makes sense!
colin-axner
approved these changes
Jun 7, 2023
|
opened #3776 for params migrations handlers 👍 |
mergify bot
pushed a commit
that referenced
this pull request
Jun 7, 2023
(cherry picked from commit c5fd97d)
crodriguezvega
pushed a commit
that referenced
this pull request
Jun 7, 2023
(cherry picked from commit c5fd97d) Co-authored-by: Carlos Rodriguez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.