ICS20 authz E2E happy path #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
commented
Jan 11, 2023
Comment on lines
+568
to
+573
| func getValidatorsAndFullNodes() (int, int) { | ||
| if testconfig.IsCI() { | ||
| return 4, 1 | ||
| } | ||
| return 1, 0 | ||
| } |
There was a problem hiding this comment.
unrelated QOL change to allow running tests locally to run faster.
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei and
damiannolan
as code owners
9 tasks
damiannolan
approved these changes
Jan 11, 2023
Comment on lines
+568
to
+573
| func getValidatorsAndFullNodes() (int, int) { | ||
| if testconfig.IsCI() { | ||
| return 4, 1 | ||
| } | ||
| return 1, 0 | ||
| } |
e2e/tests/transfer/authz_test.go
Outdated
| suite.Require().NoError(err) | ||
| }) | ||
|
|
||
| t.Run("exec MsgTransfer", func(t *testing.T) { |
There was a problem hiding this comment.
wonder if we should reword this a little
Suggested change
| t.Run("exec MsgTransfer", func(t *testing.T) { | |
| t.Run("broadcast MsgExec for ibc MsgTransfer", func(t *testing.T) { |
charleenfei
reviewed
Jan 11, 2023
| @@ -129,6 +130,13 @@ func GetChainBTag() string { | |||
| return chainBTag | |||
| } | |||
|
|
|||
| // IsCI returns true if the tests are running in CI, false is returned | |||
| // if the tests are running locally. | |||
| // Note: github actions passes a CI env value of true by default to all runners. | |||
e2e/tests/transfer/authz_test.go
Outdated
| suite.Require().Equal(testvalues.IBCTransferAmount, actualBalance) | ||
| }) | ||
|
|
||
| t.Run("granter grant spend limit reduced", func(t *testing.T) { |
There was a problem hiding this comment.
should we try to broadcast another MsgGrant to make sure it overwrites the first?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #2964
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.