Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authz/ics20: add e2e tests #2964

Closed
crodriguezvega opened this issue Dec 21, 2022 · 1 comment
Closed

authz/ics20: add e2e tests #2964

crodriguezvega opened this issue Dec 21, 2022 · 1 comment
Assignees
Milestone

Comments

@crodriguezvega
Copy link
Contributor

  • One happy path where the granter can grant privileges to the grantee and the grantee succeeds on transferring tokens to the recipient.
  • One unhappy path where the grantee does not have privileges and the attempt to transfer tokens fails.

Open PRs against the feature branch.

@crodriguezvega crodriguezvega changed the title authz/ics20:add e2e tests authz/ics20: add e2e tests Dec 21, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Dec 21, 2022
@crodriguezvega crodriguezvega added this to the v7.0.0 milestone Dec 21, 2022
@chatton
Copy link
Contributor

chatton commented Jan 9, 2023

One thing to keep in mind is that we run all our E2E tests against main, so the E2E test itself can be on main, but the images used need to be built from the feature branch.

However if we need to use ibc-go types from the feature branch, then opening a PR against the feature branch might be the best option.

EDIT: we will need types from the fork, let's add the test to the fork as originally suggested!

@chatton chatton self-assigned this Jan 10, 2023
@chatton chatton moved this from Todo to In review in ibc-go Jan 11, 2023
@chatton chatton closed this as completed Jan 18, 2023
@github-project-automation github-project-automation bot moved this from In review to Todo in ibc-go Jan 18, 2023
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🥳
Development

No branches or pull requests

3 participants