Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export connection params #242

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Jul 7, 2021

Description

tested locally

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@AdityaSripal AdityaSripal merged commit 980e185 into main Jul 7, 2021
@AdityaSripal AdityaSripal deleted the colin/export-max-expected-block-time branch July 7, 2021 12:46
colin-axner added a commit that referenced this pull request Jul 7, 2021
colin-axner added a commit that referenced this pull request Jul 7, 2021
* Fix/channel open/close events (#220)

* fix: moving  event to keeper function instead of rpc handler

* refactor: removing unnecessary handler

* refactor: delete channel handler file

* Apply suggestions from code review

Co-authored-by: Aditya <[email protected]>

* ibc: fix metrics (#223)

* add missing changelog entries (#230)

* add missing changelog entries

* add missing entry

* Fix missing events in OnRecvPacket (#233)

* fix to set events to the original context

* Update modules/core/keeper/msg_server.go

Co-authored-by: Aditya <[email protected]>
Co-authored-by: colin axnér <[email protected]>

* bump SDK dependency to v0.43.0-rc0 (#229)

Co-authored-by: Aditya <[email protected]>

* Sentinel Root Fix (#234)

* fix sentinel value

* add godoc and test

* fix grammar

* add changelog

Co-authored-by: colin axnér <[email protected]>

* export connection params (#242)

* ensure latest height revision number matches chain id revision number (#241)

* ensure latest height revision number matches chain id revision number

fix tests as well

* add changelog

* Update modules/light-clients/07-tendermint/types/client_state_test.go

* Update modules/light-clients/07-tendermint/types/client_state_test.go

* address review suggestions

* fix merge conflict

Co-authored-by: Sean King <[email protected]>
Co-authored-by: Aditya <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Jun Kimura <[email protected]>
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this pull request Nov 6, 2023
* feat: ConsensusState/DumpConsensusState implementation

Resolves cosmos#242
Resolves cosmos#243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants