Fix/channel open/close events #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seantking
requested review from
AdityaSripal,
colin-axner and
fedekunze
as code owners
seantking
force-pushed
the
fix/channel-open-init-event
branch
from
fe7fdbf to
505e7ce
Compare
AdityaSripal
requested changes
Jun 18, 2021
modules/core/keeper/msg_server.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| return &channeltypes.MsgChannelOpenTryResponse{}, sdkerrors.Wrap(err, "channel handshake open try failed") |
There was a problem hiding this comment.
Return nil here, since that's what the rest of the file does
Codecov Report
@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 79.33% 79.46% +0.12%
==========================================
Files 115 115
Lines 6746 6837 +91
==========================================
+ Hits 5352 5433 +81
- Misses 1016 1026 +10
Partials 378 378
|
seantking
force-pushed
the
fix/channel-open-init-event
branch
from
505e7ce to
5ddd31b
Compare
I would prefer to do another PR if possible. This is currently blocking some of the work that I'm trying to get done. Happy to do that Monday though 👍 |
AdityaSripal
approved these changes
Jun 18, 2021
colin-axner
pushed a commit
that referenced
this pull request
Jul 5, 2021
* fix: moving event to keeper function instead of rpc handler * refactor: removing unnecessary handler * refactor: delete channel handler file * Apply suggestions from code review Co-authored-by: Aditya <[email protected]>
colin-axner
pushed a commit
that referenced
this pull request
Jul 5, 2021
* fix: moving event to keeper function instead of rpc handler * refactor: removing unnecessary handler * refactor: delete channel handler file * Apply suggestions from code review Co-authored-by: Aditya <[email protected]>
colin-axner
added a commit
that referenced
this pull request
Jul 7, 2021
* Fix/channel open/close events (#220) * fix: moving event to keeper function instead of rpc handler * refactor: removing unnecessary handler * refactor: delete channel handler file * Apply suggestions from code review Co-authored-by: Aditya <[email protected]> * ibc: fix metrics (#223) * add missing changelog entries (#230) * add missing changelog entries * add missing entry * Fix missing events in OnRecvPacket (#233) * fix to set events to the original context * Update modules/core/keeper/msg_server.go Co-authored-by: Aditya <[email protected]> Co-authored-by: colin axnér <[email protected]> * bump SDK dependency to v0.43.0-rc0 (#229) Co-authored-by: Aditya <[email protected]> * Sentinel Root Fix (#234) * fix sentinel value * add godoc and test * fix grammar * add changelog Co-authored-by: colin axnér <[email protected]> * export connection params (#242) * ensure latest height revision number matches chain id revision number (#241) * ensure latest height revision number matches chain id revision number fix tests as well * add changelog * Update modules/light-clients/07-tendermint/types/client_state_test.go * Update modules/light-clients/07-tendermint/types/client_state_test.go * address review suggestions * fix merge conflict Co-authored-by: Sean King <[email protected]> Co-authored-by: Aditya <[email protected]> Co-authored-by: Aleksandr Bezobchuk <[email protected]> Co-authored-by: Jun Kimura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing the channel modules
handler.gofile entirely. Events are now emitted directly from the different keeper functions for opening/closing channels.closes: #219
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes