merge to main

cosmos · Aug 29, 2023 · 3d627a9 · 3d627a9
2 parents efa5e43 + 5916683
commit 3d627a9
Show file tree

Hide file tree

Showing 117 changed files with 2,440 additions and 1,072 deletions.
diff --git a/.github/compatibility-test-matrices/main/client-chain-b.json b/.github/compatibility-test-matrices/main/client-chain-b.json
@@ -17,8 +17,7 @@
   ],
   "test": [
     "TestClientUpdateProposal_Succeeds",
-    "TestClient_Update_Misbehaviour",
-    "TestAllowedClientsParam"
+    "TestClient_Update_Misbehaviour"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/main/ica-chain-a.json b/.github/compatibility-test-matrices/main/ica-chain-a.json
@@ -15,8 +15,7 @@
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
     "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
-    "TestControllerEnabledParam",
-    "TestHostEnabledParam"
+    "TestControllerEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/main/ica-chain-b.json b/.github/compatibility-test-matrices/main/ica-chain-b.json
@@ -15,7 +15,6 @@
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
     "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
-    "TestControllerEnabledParam",
     "TestHostEnabledParam"
   ],
   "relayer-type": [

diff --git a/.github/compatibility-test-matrices/main/transfer-chain-b.json b/.github/compatibility-test-matrices/main/transfer-chain-b.json
@@ -19,9 +19,7 @@
     "TestMsgTransfer_Succeeds_Nonincentivized",
     "TestMsgTransfer_Fails_InvalidAddress",
     "TestMsgTransfer_Timeout_Nonincentivized",
-    "TestMsgTransfer_WithMemo",
-    "TestSendEnabledParam",
-    "TestReceiveEnabledParam"
+    "TestMsgTransfer_WithMemo"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v4.4.x/transfer-chain-b.json b/.github/compatibility-test-matrices/release-v4.4.x/transfer-chain-b.json
@@ -18,9 +18,7 @@
     "TestMsgTransfer_Succeeds_Nonincentivized",
     "TestMsgTransfer_Fails_InvalidAddress",
     "TestMsgTransfer_Timeout_Nonincentivized",
-    "TestMsgTransfer_WithMemo",
-    "TestSendEnabledParam",
-    "TestReceiveEnabledParam"
+    "TestMsgTransfer_WithMemo"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v5.2.x/transfer-chain-b.json b/.github/compatibility-test-matrices/release-v5.2.x/transfer-chain-b.json
@@ -18,9 +18,7 @@
     "TestMsgTransfer_Succeeds_Nonincentivized",
     "TestMsgTransfer_Fails_InvalidAddress",
     "TestMsgTransfer_Timeout_Nonincentivized",
-    "TestMsgTransfer_WithMemo",
-    "TestSendEnabledParam",
-    "TestReceiveEnabledParam"
+    "TestMsgTransfer_WithMemo"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v5.3.x/transfer-chain-b.json b/.github/compatibility-test-matrices/release-v5.3.x/transfer-chain-b.json
@@ -18,9 +18,7 @@
     "TestMsgTransfer_Succeeds_Nonincentivized",
     "TestMsgTransfer_Fails_InvalidAddress",
     "TestMsgTransfer_Timeout_Nonincentivized",
-    "TestMsgTransfer_WithMemo",
-    "TestSendEnabledParam",
-    "TestReceiveEnabledParam"
+    "TestMsgTransfer_WithMemo"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v6.1.x/client-chain-b.json b/.github/compatibility-test-matrices/release-v6.1.x/client-chain-b.json
@@ -16,8 +16,7 @@
   ],
   "test": [
     "TestClientUpdateProposal_Succeeds",
-    "TestClient_Update_Misbehaviour",
-    "TestAllowedClientsParam"
+    "TestClient_Update_Misbehaviour"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v6.1.x/ica-chain-a.json b/.github/compatibility-test-matrices/release-v6.1.x/ica-chain-a.json
@@ -15,8 +15,7 @@
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
     "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
-    "TestControllerEnabledParam",
-    "TestHostEnabledParam"
+    "TestControllerEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v6.1.x/ica-chain-b.json b/.github/compatibility-test-matrices/release-v6.1.x/ica-chain-b.json
@@ -15,7 +15,6 @@
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
     "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
-    "TestControllerEnabledParam",
     "TestHostEnabledParam"
   ],
   "relayer-type": [

diff --git a/.github/compatibility-test-matrices/release-v6.1.x/transfer-chain-b.json b/.github/compatibility-test-matrices/release-v6.1.x/transfer-chain-b.json
@@ -18,9 +18,7 @@
     "TestMsgTransfer_Succeeds_Nonincentivized",
     "TestMsgTransfer_Fails_InvalidAddress",
     "TestMsgTransfer_Timeout_Nonincentivized",
-    "TestMsgTransfer_WithMemo",
-    "TestSendEnabledParam",
-    "TestReceiveEnabledParam"
+    "TestMsgTransfer_WithMemo"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v6.2.x/client-chain-b.json b/.github/compatibility-test-matrices/release-v6.2.x/client-chain-b.json
@@ -16,8 +16,7 @@
   ],
   "test": [
     "TestClientUpdateProposal_Succeeds",
-    "TestClient_Update_Misbehaviour",
-    "TestAllowedClientsParam"
+    "TestClient_Update_Misbehaviour"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v6.2.x/ica-chain-a.json b/.github/compatibility-test-matrices/release-v6.2.x/ica-chain-a.json
@@ -15,8 +15,7 @@
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
     "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
-    "TestControllerEnabledParam",
-    "TestHostEnabledParam"
+    "TestControllerEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v6.2.x/ica-chain-b.json b/.github/compatibility-test-matrices/release-v6.2.x/ica-chain-b.json
@@ -15,7 +15,6 @@
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
     "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
-    "TestControllerEnabledParam",
     "TestHostEnabledParam"
   ],
   "relayer-type": [

diff --git a/.github/compatibility-test-matrices/release-v6.2.x/transfer-chain-b.json b/.github/compatibility-test-matrices/release-v6.2.x/transfer-chain-b.json
@@ -18,9 +18,7 @@
     "TestMsgTransfer_Succeeds_Nonincentivized",
     "TestMsgTransfer_Fails_InvalidAddress",
     "TestMsgTransfer_Timeout_Nonincentivized",
-    "TestMsgTransfer_WithMemo",
-    "TestSendEnabledParam",
-    "TestReceiveEnabledParam"
+    "TestMsgTransfer_WithMemo"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v7.2.x/client-chain-b.json b/.github/compatibility-test-matrices/release-v7.2.x/client-chain-b.json
@@ -16,8 +16,7 @@
   ],
   "test": [
     "TestClientUpdateProposal_Succeeds",
-    "TestClient_Update_Misbehaviour",
-    "TestAllowedClientsParam"
+    "TestClient_Update_Misbehaviour"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v7.2.x/ica-chain-a.json b/.github/compatibility-test-matrices/release-v7.2.x/ica-chain-a.json
@@ -15,8 +15,7 @@
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
     "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
-    "TestControllerEnabledParam",
-    "TestHostEnabledParam"
+    "TestControllerEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v7.2.x/ica-chain-b.json b/.github/compatibility-test-matrices/release-v7.2.x/ica-chain-b.json
@@ -15,7 +15,6 @@
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
     "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
-    "TestControllerEnabledParam",
     "TestHostEnabledParam"
   ],
   "relayer-type": [

diff --git a/.github/compatibility-test-matrices/release-v7.2.x/transfer-chain-b.json b/.github/compatibility-test-matrices/release-v7.2.x/transfer-chain-b.json
@@ -18,9 +18,7 @@
     "TestMsgTransfer_Succeeds_Nonincentivized",
     "TestMsgTransfer_Fails_InvalidAddress",
     "TestMsgTransfer_Timeout_Nonincentivized",
-    "TestMsgTransfer_WithMemo",
-    "TestSendEnabledParam",
-    "TestReceiveEnabledParam"
+    "TestMsgTransfer_WithMemo"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v7.3.x/client-chain-b.json b/.github/compatibility-test-matrices/release-v7.3.x/client-chain-b.json
@@ -16,8 +16,7 @@
   ],
   "test": [
     "TestClientUpdateProposal_Succeeds",
-    "TestClient_Update_Misbehaviour",
-    "TestAllowedClientsParam"
+    "TestClient_Update_Misbehaviour"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v7.3.x/ica-chain-a.json b/.github/compatibility-test-matrices/release-v7.3.x/ica-chain-a.json
@@ -15,8 +15,7 @@
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
     "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
-    "TestControllerEnabledParam",
-    "TestHostEnabledParam"
+    "TestControllerEnabledParam"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/compatibility-test-matrices/release-v7.3.x/ica-chain-b.json b/.github/compatibility-test-matrices/release-v7.3.x/ica-chain-b.json
@@ -15,7 +15,6 @@
     "TestMsgSendTx_SuccessfulTransfer",
     "TestMsgSendTx_FailedTransfer_InsufficientFunds",
     "TestMsgSendTx_SuccessfulTransfer_AfterReopeningICA",
-    "TestControllerEnabledParam",
     "TestHostEnabledParam"
   ],
   "relayer-type": [

diff --git a/.github/compatibility-test-matrices/release-v7.3.x/transfer-chain-b.json b/.github/compatibility-test-matrices/release-v7.3.x/transfer-chain-b.json
@@ -18,9 +18,7 @@
     "TestMsgTransfer_Succeeds_Nonincentivized",
     "TestMsgTransfer_Fails_InvalidAddress",
     "TestMsgTransfer_Timeout_Nonincentivized",
-    "TestMsgTransfer_WithMemo",
-    "TestSendEnabledParam",
-    "TestReceiveEnabledParam"
+    "TestMsgTransfer_WithMemo"
   ],
   "relayer-type": [
     "rly"

diff --git a/.github/workflows/build-callbacks-simd-image-from-tag.yml b/.github/workflows/build-callbacks-simd-image-from-tag.yml
@@ -0,0 +1,35 @@
+name: Build Callbacks Simd Image
+on:
+  workflow_dispatch:
+    inputs:
+      tag:
+        description: 'The tag of the image to build'
+        required: true
+        type: string
+
+env:
+   REGISTRY: ghcr.io
+   ORG: cosmos
+   IMAGE_NAME: ibc-go-callbacks-simd
+   GIT_TAG: "${{ inputs.tag }}"
+
+jobs:
+   build-image-at-tag:
+      runs-on: ubuntu-latest
+      steps:
+         - uses: actions/checkout@v3
+           with:
+            ref: "${{ env.GIT_TAG }}"
+            fetch-depth: 0
+         - name: Log in to the Container registry
+           uses: docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc
+           with:
+              registry: ${{ env.REGISTRY }}
+              username: ${{ github.actor }}
+              password: ${{ secrets.GITHUB_TOKEN }}
+         - name: Build image
+           run: |
+            # remove any `/` characters from the docker tag and replace them with a -
+            docker_tag="$(echo $GIT_TAG | sed 's/\//-/')"
+            docker build . -t "${REGISTRY}/${ORG}/${IMAGE_NAME}:${docker_tag}" -f modules/apps/callbacks/Dockerfile
+            docker push "${REGISTRY}/${ORG}/${IMAGE_NAME}:${docker_tag}"
diff --git a/.github/workflows/callbacks.yml b/.github/workflows/callbacks.yml
@@ -18,7 +18,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: golangci/[email protected]
         with:
-          version: v1.53.3
+          version: v1.54.2
           args: --timeout 5m
           working-directory: modules/apps/callbacks
 

diff --git a/docs/.vuepress/config.js b/docs/.vuepress/config.js
@@ -533,6 +533,43 @@ module.exports = {
                 },
               ],
             },
+            {
+              title: "Callbacks Middleware",
+              directory: true,
+              path: "/middleware",
+              children: [
+                {
+                  title: "Overview",
+                  directory: false,
+                  path: "/middleware/callbacks/overview.html",
+                },
+                {
+                  title: "Integration",
+                  directory: false,
+                  path: "/middleware/callbacks/integration.html",
+                },
+                {
+                  title: "Interfaces",
+                  directory: false,
+                  path: "/middleware/callbacks/interfaces.html",
+                },
+                {
+                  title: "Events",
+                  directory: false,
+                  path: "/middleware/callbacks/events.html",
+                },
+                {
+                  title: "End Users",
+                  directory: false,
+                  path: "/middleware/callbacks/end-users.html",
+                },
+                {
+                  title: "Gas Management",
+                  directory: false,
+                  path: "/middleware/callbacks/gas.html",
+                },
+              ],
+            },
           ],
         },
         {

diff --git a/docs/apps/transfer/params.md b/docs/apps/transfer/params.md
@@ -75,8 +75,8 @@ To change the parameter values, you must make a governance proposal that execute
 
 // MsgUpdateParams is the Msg/UpdateParams request type.
 message MsgUpdateParams {
-  // authority is the address that controls the module (defaults to x/gov unless overwritten).
-  string authority = 1;
+  // signer address (it may be the the address that controls the module, which defaults to x/gov unless overwritten).
+  string signer = 1;
 
   // params defines the transfer parameters to update.
   //

diff --git a/docs/assets/callbacks-mw/callbackflow.svg b/docs/assets/callbacks-mw/callbackflow.svg
diff --git a/docs/assets/callbacks-mw/ics4-callbackflow.svg b/docs/assets/callbacks-mw/ics4-callbackflow.svg
diff --git a/docs/ibc/apps/ibcmodule.md b/docs/ibc/apps/ibcmodule.md
@@ -347,3 +347,26 @@ func (im IBCModule) OnTimeoutPacket(
   // do custom timeout logic
 }
 ```
+
+### Optional interfaces
+
+The following interface are optional and MAY be implemented by an IBCModule.
+
+#### PacketDataUnmarshaler
+
+The `PacketDataUnmarshaler` interface is defined as follows:
+
+```go
+// PacketDataUnmarshaler defines an optional interface which allows a middleware to
+// request the packet data to be unmarshaled by the base application.
+type PacketDataUnmarshaler interface {
+	// UnmarshalPacketData unmarshals the packet data into a concrete type
+	UnmarshalPacketData([]byte) (interface{}, error)
+}
+```
+
+The implementation of `UnmarshalPacketData` should unmarshal the bytes into the packet data type defined for an IBC stack. 
+The base application of an IBC stack should unmarshal the bytes into its packet data type, while a middleware may simply defer the call to the underlying application.
+
+This interface allows middlewares to unmarshal a packet data in order to make use of interfaces the packet data type implements. 
+For example, the callbacks middleware makes use of this function to access packet data types which implement the `PacketData` and `PacketDataProvider` interfaces.