update authority -> signers

modules/core/02-client/types/msgs.go

@@ -287,22 +287,22 @@ func (msg *MsgUpdateParams) ValidateBasic() error {
 }
 
 // NewMsgIBCSoftwareUpgrade creates a new MsgIBCSoftwareUpgrade instance
-func NewMsgIBCSoftwareUpgrade(authority string, plan upgradetypes.Plan, upgradedClientState exported.ClientState) (*MsgIBCSoftwareUpgrade, error) {
+func NewMsgIBCSoftwareUpgrade(signer string, plan upgradetypes.Plan, upgradedClientState exported.ClientState) (*MsgIBCSoftwareUpgrade, error) {
 	anyClient, err := PackClientState(upgradedClientState)
 	if err != nil {
 		return nil, err
 	}
 
 	return &MsgIBCSoftwareUpgrade{
-		Authority:           authority,
+		Signer:              signer,
 		Plan:                plan,
 		UpgradedClientState: anyClient,
 	}, nil
 }
 
 // GetSigners returns the expected signers for a MsgIBCSoftwareUpgrade message.
 func (msg *MsgIBCSoftwareUpgrade) GetSigners() []sdk.AccAddress {
-	accAddr, err := sdk.AccAddressFromBech32(msg.Authority)
+	accAddr, err := sdk.AccAddressFromBech32(msg.Signer)
 	if err != nil {
 		panic(err)
 	}
@@ -311,7 +311,7 @@ func (msg *MsgIBCSoftwareUpgrade) GetSigners() []sdk.AccAddress {
 
 // ValidateBasic performs basic checks on a MsgIBCSoftwareUpgrade.
 func (msg *MsgIBCSoftwareUpgrade) ValidateBasic() error {
-	if _, err := sdk.AccAddressFromBech32(msg.Authority); err != nil {
+	if _, err := sdk.AccAddressFromBech32(msg.Signer); err != nil {
 		return errorsmod.Wrapf(ibcerrors.ErrInvalidAddress, "string could not be parsed as address: %v", err)
 	}
 

modules/core/02-client/types/msgs_test.go

@@ -717,7 +717,7 @@ func (suite *TypesTestSuite) TestMsgIBCSoftwareUpgrade_NewMsgIBCSoftwareUpgrade(
 
 		if tc.expPass {
 			suite.Require().NoError(err)
-			suite.Assert().Equal(ibctesting.TestAccAddress, msg.Authority)
+			suite.Assert().Equal(ibctesting.TestAccAddress, msg.Signer)
 			suite.Assert().Equal(plan, msg.Plan)
 			unpackedClientState, err := types.UnpackClientState(msg.UpgradedClientState)
 			suite.Require().NoError(err)
@@ -771,7 +771,7 @@ func (suite *TypesTestSuite) TestMsgIBCSoftwareUpgrade_GetSigners() {
 // TestMsgIBCSoftwareUpgrade_ValidateBasic tests ValidateBasic for MsgIBCSoftwareUpgrade
 func (suite *TypesTestSuite) TestMsgIBCSoftwareUpgrade_ValidateBasic() {
 	var (
-		authority string
+		signer    string
 		plan      upgradetypes.Plan
 		anyClient *codectypes.Any
 	)
@@ -788,7 +788,7 @@ func (suite *TypesTestSuite) TestMsgIBCSoftwareUpgrade_ValidateBasic() {
 		{
 			"failure: invalid authority address",
 			func() {
-				authority = "invalid"
+				signer = "invalid"
 			},
 			ibcerrors.ErrInvalidAddress,
 		},
@@ -809,7 +809,7 @@ func (suite *TypesTestSuite) TestMsgIBCSoftwareUpgrade_ValidateBasic() {
 	}
 
 	for _, tc := range testCases {
-		authority = ibctesting.TestAccAddress
+		signer = ibctesting.TestAccAddress
 		plan = upgradetypes.Plan{
 			Name:   "upgrade IBC clients",
 			Height: 1000,
@@ -822,9 +822,9 @@ func (suite *TypesTestSuite) TestMsgIBCSoftwareUpgrade_ValidateBasic() {
 		tc.malleate()
 
 		msg := types.MsgIBCSoftwareUpgrade{
-			authority,
 			plan,
 			anyClient,
+			signer,
 		}
 
 		err = msg.ValidateBasic()