feat: implement the lazy_set feature
#750
Conversation
cmd/dbgenerator/README.md
Outdated
| ## Usage | ||
|
|
||
| It takes 4 arguments: | ||
| - dbtype: the type of database to use. |
There was a problem hiding this comment.
Can dbtype be inferred from the database?
There was a problem hiding this comment.
maybe, the purpose of this tool is to generate the legacy tree, it can be used in benchmarking and dbtype is useful to compare different db performance
|
@cool-develope seems some tests are still failing |
it seems like the dbdir removing is not working properly in GA |
| @@ -21,7 +21,7 @@ type KVPairReceiver func(pair *KVPair) error | |||
| // | |||
| // The algorithm don't run in constant memory strictly, but it tried the best the only | |||
| // keep minimal intermediate states in memory. | |||
| func (ndb *nodeDB) extractStateChanges(prevVersion int64, prevRoot *NodeKey, root *NodeKey, receiver KVPairReceiver) error { | |||
| func (ndb *nodeDB) extractStateChanges(prevVersion int64, prevRoot, root []byte, receiver KVPairReceiver) error { | |||
There was a problem hiding this comment.
I'm a big fan of this change in particular. Actually it's what I originally recommended. #676 (review)
| leftNodeKey *NodeKey | ||
| rightNodeKey *NodeKey | ||
| leftNodeKey []byte | ||
| rightNodeKey []byte |
There was a problem hiding this comment.
I propose taking this further. Why not define nodeKey []byte and store version and nonce as private, top-level fields on Node?
There was a problem hiding this comment.
[]byte nodeKey is meaningless, leftNodeKey and rightNodeKey is used in getting children
The only thing we need is nonce and version
There was a problem hiding this comment.
NodeKey seems also without meaning, just makes the code harder to read. if we need nonce and version why not put it on Node directly?
There was a problem hiding this comment.
good question, the nonce and version are used together in several encodings, so I created the specific struct NodeKey
and also it ensures version+nonce as a node key
we should probably use |
migrate_test.go
Outdated
| } | ||
| } | ||
|
|
||
| cmd := exec.Command("sh", "-c", fmt.Sprintf("cd cmd/dbgenerator && go run . %s %s random %d %d", dbType, dbDir, version, version/2)) //nolint:gosec |
There was a problem hiding this comment.
Can we import it as library, since it's all golang code here
There was a problem hiding this comment.
it will cause circular dependency since we are in v1, go.mod doesn't analyze the iavl imports
|
@tac0turtle , it seems like 5mins is not enough for test since I added |
Closes: #747