Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor the node struct #748

Merged
merged 2 commits into from
Apr 19, 2023
Merged

feat: refactor the node struct #748

merged 2 commits into from
Apr 19, 2023

Conversation

cool-develope
Copy link
Collaborator

ref: #747

It refactored the node struct as discussed in #747.
leftNodeKey and rightNodeKey types are changed from *NodeKey to []byte to allow the reference of the old key format (node hash).

@cool-develope cool-develope requested a review from a team as a code owner April 18, 2023 12:55
@cool-develope
Copy link
Collaborator Author

@yihuang do you have a chance to review this change?

tac0turtle
tac0turtle approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cool-develope cool-develope changed the base branch from master to lazy_set April 19, 2023 12:07
@cool-develope
Copy link
Collaborator Author

will test and benchmark in the final step

@cool-develope cool-develope merged commit 142f734 into lazy_set Apr 19, 2023
@cool-develope cool-develope deleted the 747/node_refactor branch April 19, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cool-develope @tac0turtle